chrome/browser/safe_browsing/safe_browsing_tab_observer.h - Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_tab_observer.h

Issue 1870003002: Convert //chrome/browser/safe_browsing from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and address comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_tab_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_tab_observer.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_tab_observer.h b/chrome/browser/safe_browsing/safe_browsing_tab_observer.h

index ded7b04144d1161d4f97a69e29ef8fdbdf0d3fd9..8cc9608e40660068f6bc5aaad7aea273b532f1c0 100644

--- a/chrome/browser/safe_browsing/safe_browsing_tab_observer.h

+++ b/chrome/browser/safe_browsing/safe_browsing_tab_observer.h

@@ -5,8 +5,9 @@

#ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_TAB_OBSERVER_H_

#define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_TAB_OBSERVER_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "components/prefs/pref_change_registrar.h"

#include "content/public/browser/web_contents_user_data.h"

@@ -35,7 +36,7 @@ class SafeBrowsingTabObserver

void UpdateSafebrowsingDetectionHost();

// Handles IPCs.

- scoped_ptr<ClientSideDetectionHost> safebrowsing_detection_host_;

+ std::unique_ptr<ClientSideDetectionHost> safebrowsing_detection_host_;

// Our owning WebContents.

content::WebContents* web_contents_;