Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 18699: Fix a bug when saving web pages that have a period in their title (Closed)

Created:
10 years, 7 months ago by Paul Godavari
Modified:
8 years, 3 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix a bug when saving web pages that have a period in their title. The save dialog code attempts to generate a file extension based on the suggested name provided to it, which in the case of saving a web page is the title. If that title contains a '.' character, it treats anything that follows as the file extension and appends it to the name the user selects. For example, saving a page with the title "Google Inc. - A search engine" and the user choosing the save name as "Google" will result in the saved file being named "Google. - A search engine.htm" when it should be "Google.htm". In the case of saving a web page, we can ignore trying to figure out the file extension since we already know it will be ".htm". BUG=6105 (http://crbug.com/6105) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8569

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/browser/download/save_package.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/views/shell_dialogs.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/win_util.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/common/win_util.cc View 1 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Godavari
10 years, 7 months ago (2009-01-23 01:43:08 UTC) #1
Ben Goodger (Google)
http://codereview.chromium.org/18699/diff/1/2 File chrome/browser/views/shell_dialogs.cc (right): http://codereview.chromium.org/18699/diff/1/2#newcode307 Line 307: filter, default_extension, false, &index, &path); does this mean ...
10 years, 7 months ago (2009-01-23 01:57:21 UTC) #2
Paul Godavari
http://codereview.chromium.org/18699/diff/1/2 File chrome/browser/views/shell_dialogs.cc (right): http://codereview.chromium.org/18699/diff/1/2#newcode307 Line 307: filter, default_extension, false, &index, &path); On 2009/01/23 01:57:21, ...
10 years, 7 months ago (2009-01-23 02:10:11 UTC) #3
Ben Goodger (Google)
10 years, 7 months ago (2009-01-23 02:29:09 UTC) #4
LGTM with the comment we discussed.

Powered by Google App Engine
This is Rietveld 408576698