Fix a bug when saving web pages that have a period in their title

Fix a bug when saving web pages that have a period in their title.

The save dialog code attempts to generate a file extension based on
the suggested name provided to it, which in the case of saving a web
page is the title. If that title contains a '.' character, it treats
anything that follows as the file extension and appends it to the name
the user selects.

For example, saving a page with the title "Google Inc. - A search engine"
and the user choosing the save name as "Google" will result in the saved
file being named "Google. - A search engine.htm" when it should be
"Google.htm".

In the case of saving a web page, we can ignore trying to figure out
the file extension since we already know it will be ".htm".

BUG=6105
(http://crbug.com/6105)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8569

[Ben Goodger (Google), 2009-01-23 01:57:21]

http://codereview.chromium.org/18699/diff/1/2
File chrome/browser/views/shell_dialogs.cc (right):

http://codereview.chromium.org/18699/diff/1/2#newcode307
Line 307: filter, default_extension, false, &index, &path);
does this mean that if the file has an extension, it'll be ingored even if it's
valid?

http://codereview.chromium.org/18699/diff/1/5
File chrome/common/win_util.h (right):

http://codereview.chromium.org/18699/diff/1/5#newcode182
Line 182: bool ingore_suggested_ext,
ingore? ;-)

also please add a comment here explaining what this is for and in what
circumstances you might use it (e.g. suggested name that is text such as the
title of a page).

[Paul Godavari, 2009-01-23 02:10:11]

http://codereview.chromium.org/18699/diff/1/2
File chrome/browser/views/shell_dialogs.cc (right):

http://codereview.chromium.org/18699/diff/1/2#newcode307
Line 307: filter, default_extension, false, &index, &path);
On 2009/01/23 01:57:21, Ben Goodger wrote:
> does this mean that if the file has an extension, it'll
> be ignored even if it's valid?

It will only be ignored when 'true' is specified. All file saving will behave as
before except the SavePage code, which needs to ignore possible extensions since
its suggested_name is a title, not a file name (which may contain '.').

[Ben Goodger (Google), 2009-01-23 02:29:09]

LGTM with the comment we discussed.