Fix a bug when saving web pages that have a period in their title

chrome/common/win_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/win_util.h"
 
 #include <atlbase.h>
 #include <atlapp.h>
 #include <commdlg.h>
 #include <dwmapi.h>
@@ skipping 369 matching lines @@
 
 bool SaveFileAs(HWND owner,
                 const std::wstring& suggested_name,
                 std::wstring* final_name) {
   std::wstring filter = GetFileFilterFromPath(suggested_name);
   unsigned index = 1;
   return SaveFileAsWithFilter(owner,
                               suggested_name,
                               filter,
                               L"",
+                              false,
                               &index,
                               final_name);
 }
 
 bool SaveFileAsWithFilter(HWND owner,
                           const std::wstring& suggested_name,
                           const std::wstring& filter,
                           const std::wstring& def_ext,
+                          bool ignore_suggested_ext,
                           unsigned* index,
                           std::wstring* final_name) {
   DCHECK(final_name);
   // Having an empty filter makes for a bad user experience. We should always
   // specify a filter when saving.
   DCHECK(!filter.empty());
   std::wstring file_part = file_util::GetFilenameFromPath(suggested_name);
 
   // The size of the in/out buffer in number of characters we pass to win32
   // GetSaveFileName.  From MSDN "The buffer must be large enough to store the
@@ skipping 57 matching lines @@
   // the example above, if the first index was selected we need to skip 1
   // instance of null to get to "*.jpg".
   std::vector<std::wstring> filters;
   if (!filter.empty() && save_as.nFilterIndex > 0)
     SplitString(filter, '\0', &filters);
   std::wstring filter_selected;
   if (!filters.empty())
     filter_selected = filters[(2 * (save_as.nFilterIndex - 1)) + 1];
 
   // Get the extension that was suggested to the user (when the Save As dialog
-  // was opened).
-  std::wstring suggested_ext =
-      file_util::GetFileExtensionFromPath(suggested_name);
+  // was opened). For saving web pages, we skip this step since there may be
+  // 'extension characters' in the title of the web page.
+  std::wstring suggested_ext;
+  if (!ignore_suggested_ext)
+    suggested_ext = file_util::GetFileExtensionFromPath(suggested_name);
+
   // If we can't get the extension from the suggested_name, we use the default
   // extension passed in. This is to cover cases like when saving a web page,
   // where we get passed in a name without an extension and a default extension
   // along with it.
   if (suggested_ext.empty())
     suggested_ext = def_ext;
 
   *final_name =
       AppendExtensionIfNeeded(*final_name, filter_selected, suggested_ext);
   return true;
@@ skipping 404 matching lines @@
 }
 
 ChromeFont GetWindowTitleFont() {
   NONCLIENTMETRICS ncm;
   win_util::GetNonClientMetrics(&ncm);
   ScopedHFONT caption_font(CreateFontIndirect(&(ncm.lfCaptionFont)));
   return ChromeFont::CreateFont(caption_font);
 }
 
 }  // namespace win_util