Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1869833002: Update MatrixConvolutionImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -120 lines) Patch
M bench/MatrixConvolutionBench.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M fuzz/FilterFuzz.cpp View 1 2 chunks +10 lines, -12 lines 0 comments Download
M gm/imagefilters.cpp View 4 chunks +9 lines, -12 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 chunk +8 lines, -9 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +9 lines, -11 lines 0 comments Download
M include/effects/SkMatrixConvolutionImageFilter.h View 5 chunks +22 lines, -6 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 chunks +10 lines, -12 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 4 chunks +31 lines, -31 lines 0 comments Download
M tests/ImageFilterTest.cpp View 6 chunks +25 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
4 years, 8 months ago (2016-04-07 17:25:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869833002/1
4 years, 8 months ago (2016-04-07 18:35:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 18:48:18 UTC) #8
f(malita)
lgtm
4 years, 8 months ago (2016-04-08 13:54:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869833002/20001
4 years, 8 months ago (2016-04-08 14:44:21 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-08 14:54:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869833002/20001
4 years, 8 months ago (2016-04-08 15:00:21 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 15:01:23 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ef6a47b4af1ebf621682b3398916fefb90fc912e

Powered by Google App Engine
This is Rietveld 408576698