Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 1869833002: Update MatrixConvolutionImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: update to ToT Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « samplecode/SampleFilterFuzz.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkMatrixConvolutionImageFilter.h" 8 #include "SkMatrixConvolutionImageFilter.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
11 #include "SkDevice.h" 11 #include "SkDevice.h"
12 #include "SkReadBuffer.h" 12 #include "SkReadBuffer.h"
13 #include "SkWriteBuffer.h" 13 #include "SkWriteBuffer.h"
14 #include "SkRect.h" 14 #include "SkRect.h"
15 #include "SkUnPreMultiply.h" 15 #include "SkUnPreMultiply.h"
16 16
17 #if SK_SUPPORT_GPU 17 #if SK_SUPPORT_GPU
18 #include "effects/GrMatrixConvolutionEffect.h" 18 #include "effects/GrMatrixConvolutionEffect.h"
19 #endif 19 #endif
20 20
21 // We need to be able to read at most SK_MaxS32 bytes, so divide that 21 // We need to be able to read at most SK_MaxS32 bytes, so divide that
22 // by the size of a scalar to know how many scalars we can read. 22 // by the size of a scalar to know how many scalars we can read.
23 static const int32_t gMaxKernelSize = SK_MaxS32 / sizeof(SkScalar); 23 static const int32_t gMaxKernelSize = SK_MaxS32 / sizeof(SkScalar);
24 24
25 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter( 25 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(const SkISize& ke rnelSize,
26 const SkISize& kernelSize, 26 const SkScalar* k ernel,
27 const SkScalar* kernel, 27 SkScalar gain,
28 SkScalar gain, 28 SkScalar bias,
29 SkScalar bias, 29 const SkIPoint& k ernelOffset,
30 const SkIPoint& kernelOffset, 30 TileMode tileMode ,
31 TileMode tileMode, 31 bool convolveAlph a,
32 bool convolveAlpha, 32 sk_sp<SkImageFilt er> input,
33 SkImageFilter* input, 33 const CropRect* c ropRect)
34 const CropRect* cropRect) 34 : INHERITED(&input, 1, cropRect)
35 : INHERITED(1, &input, cropRect), 35 , fKernelSize(kernelSize)
36 fKernelSize(kernelSize), 36 , fGain(gain)
37 fGain(gain), 37 , fBias(bias)
38 fBias(bias), 38 , fKernelOffset(kernelOffset)
39 fKernelOffset(kernelOffset), 39 , fTileMode(tileMode)
40 fTileMode(tileMode), 40 , fConvolveAlpha(convolveAlpha) {
41 fConvolveAlpha(convolveAlpha) {
42 size_t size = (size_t) sk_64_mul(fKernelSize.width(), fKernelSize.height()); 41 size_t size = (size_t) sk_64_mul(fKernelSize.width(), fKernelSize.height());
43 fKernel = new SkScalar[size]; 42 fKernel = new SkScalar[size];
44 memcpy(fKernel, kernel, size * sizeof(SkScalar)); 43 memcpy(fKernel, kernel, size * sizeof(SkScalar));
45 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1); 44 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1);
46 SkASSERT(kernelOffset.fX >= 0 && kernelOffset.fX < kernelSize.fWidth); 45 SkASSERT(kernelOffset.fX >= 0 && kernelOffset.fX < kernelSize.fWidth);
47 SkASSERT(kernelOffset.fY >= 0 && kernelOffset.fY < kernelSize.fHeight); 46 SkASSERT(kernelOffset.fY >= 0 && kernelOffset.fY < kernelSize.fHeight);
48 } 47 }
49 48
50 SkImageFilter* SkMatrixConvolutionImageFilter::Create( 49 sk_sp<SkImageFilter> SkMatrixConvolutionImageFilter::Make(const SkISize& kernelS ize,
51 const SkISize& kernelSize, 50 const SkScalar* kernel ,
52 const SkScalar* kernel, 51 SkScalar gain,
53 SkScalar gain, 52 SkScalar bias,
54 SkScalar bias, 53 const SkIPoint& kernel Offset,
55 const SkIPoint& kernelOffset, 54 TileMode tileMode,
56 TileMode tileMode, 55 bool convolveAlpha,
57 bool convolveAlpha, 56 sk_sp<SkImageFilter> i nput,
58 SkImageFilter* input, 57 const CropRect* cropRe ct) {
59 const CropRect* cropRect) {
60 if (kernelSize.width() < 1 || kernelSize.height() < 1) { 58 if (kernelSize.width() < 1 || kernelSize.height() < 1) {
61 return nullptr; 59 return nullptr;
62 } 60 }
63 if (gMaxKernelSize / kernelSize.fWidth < kernelSize.fHeight) { 61 if (gMaxKernelSize / kernelSize.fWidth < kernelSize.fHeight) {
64 return nullptr; 62 return nullptr;
65 } 63 }
66 if (!kernel) { 64 if (!kernel) {
67 return nullptr; 65 return nullptr;
68 } 66 }
69 if ((kernelOffset.fX < 0) || (kernelOffset.fX >= kernelSize.fWidth) || 67 if ((kernelOffset.fX < 0) || (kernelOffset.fX >= kernelSize.fWidth) ||
70 (kernelOffset.fY < 0) || (kernelOffset.fY >= kernelSize.fHeight)) { 68 (kernelOffset.fY < 0) || (kernelOffset.fY >= kernelSize.fHeight)) {
71 return nullptr; 69 return nullptr;
72 } 70 }
73 return new SkMatrixConvolutionImageFilter(kernelSize, kernel, gain, bias, ke rnelOffset, 71 return sk_sp<SkImageFilter>(new SkMatrixConvolutionImageFilter(kernelSize, k ernel, gain,
74 tileMode, convolveAlpha, input, cr opRect); 72 bias, kernelO ffset,
73 tileMode, con volveAlpha,
74 std::move(inp ut), cropRect));
75 } 75 }
76 76
77 sk_sp<SkFlattenable> SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& bu ffer) { 77 sk_sp<SkFlattenable> SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& bu ffer) {
78 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); 78 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1);
79 SkISize kernelSize; 79 SkISize kernelSize;
80 kernelSize.fWidth = buffer.readInt(); 80 kernelSize.fWidth = buffer.readInt();
81 kernelSize.fHeight = buffer.readInt(); 81 kernelSize.fHeight = buffer.readInt();
82 const int count = buffer.getArrayCount(); 82 const int count = buffer.getArrayCount();
83 83
84 const int64_t kernelArea = sk_64_mul(kernelSize.width(), kernelSize.height() ); 84 const int64_t kernelArea = sk_64_mul(kernelSize.width(), kernelSize.height() );
85 if (!buffer.validate(kernelArea == count)) { 85 if (!buffer.validate(kernelArea == count)) {
86 return nullptr; 86 return nullptr;
87 } 87 }
88 SkAutoSTArray<16, SkScalar> kernel(count); 88 SkAutoSTArray<16, SkScalar> kernel(count);
89 if (!buffer.readScalarArray(kernel.get(), count)) { 89 if (!buffer.readScalarArray(kernel.get(), count)) {
90 return nullptr; 90 return nullptr;
91 } 91 }
92 SkScalar gain = buffer.readScalar(); 92 SkScalar gain = buffer.readScalar();
93 SkScalar bias = buffer.readScalar(); 93 SkScalar bias = buffer.readScalar();
94 SkIPoint kernelOffset; 94 SkIPoint kernelOffset;
95 kernelOffset.fX = buffer.readInt(); 95 kernelOffset.fX = buffer.readInt();
96 kernelOffset.fY = buffer.readInt(); 96 kernelOffset.fY = buffer.readInt();
97 TileMode tileMode = (TileMode)buffer.readInt(); 97 TileMode tileMode = (TileMode)buffer.readInt();
98 bool convolveAlpha = buffer.readBool(); 98 bool convolveAlpha = buffer.readBool();
99 return sk_sp<SkFlattenable>(Create(kernelSize, kernel.get(), gain, bias, ker nelOffset, tileMode, 99 return Make(kernelSize, kernel.get(), gain, bias, kernelOffset, tileMode,
100 convolveAlpha, common.getInput(0).get(), &com mon.cropRect())); 100 convolveAlpha, common.getInput(0), &common.cropRect());
101 } 101 }
102 102
103 void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const { 103 void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const {
104 this->INHERITED::flatten(buffer); 104 this->INHERITED::flatten(buffer);
105 buffer.writeInt(fKernelSize.fWidth); 105 buffer.writeInt(fKernelSize.fWidth);
106 buffer.writeInt(fKernelSize.fHeight); 106 buffer.writeInt(fKernelSize.fHeight);
107 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight); 107 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight);
108 buffer.writeScalar(fGain); 108 buffer.writeScalar(fGain);
109 buffer.writeScalar(fBias); 109 buffer.writeScalar(fBias);
110 buffer.writeInt(fKernelOffset.fX); 110 buffer.writeInt(fKernelOffset.fX);
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 str->appendf("%f ", fKernel[y * fKernelSize.width() + x]); 390 str->appendf("%f ", fKernel[y * fKernelSize.width() + x]);
391 } 391 }
392 } 392 }
393 str->appendf(")"); 393 str->appendf(")");
394 str->appendf("gain: %f bias: %f ", fGain, fBias); 394 str->appendf("gain: %f bias: %f ", fGain, fBias);
395 str->appendf("offset: (%d, %d) ", fKernelOffset.fX, fKernelOffset.fY); 395 str->appendf("offset: (%d, %d) ", fKernelOffset.fX, fKernelOffset.fY);
396 str->appendf("convolveAlpha: %s", fConvolveAlpha ? "true" : "false"); 396 str->appendf("convolveAlpha: %s", fConvolveAlpha ? "true" : "false");
397 str->append(")"); 397 str->append(")");
398 } 398 }
399 #endif 399 #endif
OLDNEW
« no previous file with comments | « samplecode/SampleFilterFuzz.cpp ('k') | tests/ImageFilterTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698