Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
186983003:
[Privet] Do not show notifications from guest and default profiles in ChromeOS (Closed)
|
Created:
6 years, 9 months ago by Noam Samuel Modified:
6 years, 9 months ago Reviewers:
Vitaly Buka (NO REVIEWS) CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Description[Privet] Do not show notifications from guest and default profiles in ChromeOS
In ChromeOS, do not show notifications for guest and default profiles. When
starting the privet notification service, check if the profile has an
authenticated username. If it does, it is a normal user account; otherwise it
isn't.
BUG=349098
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255432
Patch Set 1 #
Total comments: 2
Messages
Total messages: 21 (0 generated)
https://codereview.chromium.org/186983003/diff/1/chrome/browser/local_discove... File chrome/browser/local_discovery/privet_notifications.cc (right): https://codereview.chromium.org/186983003/diff/1/chrome/browser/local_discove... chrome/browser/local_discovery/privet_notifications.cc:294: if (!signin_manager || signin_manager->GetAuthenticatedUsername().empty()) I guess that's not enough. service keeps running after sign off of user, so it will show notification for the next guest after that
https://codereview.chromium.org/186983003/diff/1/chrome/browser/local_discove... File chrome/browser/local_discovery/privet_notifications.cc (right): https://codereview.chromium.org/186983003/diff/1/chrome/browser/local_discove... chrome/browser/local_discovery/privet_notifications.cc:294: if (!signin_manager || signin_manager->GetAuthenticatedUsername().empty()) On 2014/03/04 22:47:33, Vitaly Buka wrote: > I guess that's not enough. > service keeps running after sign off of user, so it will show notification for > the next guest after that Have we seen this behavior? I'd suspect notifications should only show on the desktop of the profile's user, with the default profile being an exception to that rule.
lgtm
The CQ bit was checked by vitalybuka@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by noamsml@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by vitalybuka@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
The CQ bit was checked by noamsml@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/186983003/1
Message was sent while issue was closed.
Change committed as 255432 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
