[Privet] Do not show notifications from guest and default profiles in ChromeOS

chrome/browser/local_discovery/privet_notifications.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/local_discovery/privet_notifications.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/rand_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/local_discovery/privet_device_lister_impl.h"
 #include "chrome/browser/local_discovery/privet_http_asynchronous_factory.h"
 #include "chrome/browser/local_discovery/privet_traffic_detector.h"
 #include "chrome/browser/local_discovery/service_discovery_shared_client.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/signin_manager_base.h"
+#include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/host_desktop.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/navigation_controller.h"
@@ skipping 245 matching lines @@
   }
 }
 
 void PrivetNotificationService::PrivetRemoveNotification() {
   ReportPrivetUmaEvent(PRIVET_NOTIFICATION_CANCELED);
   g_browser_process->notification_ui_manager()->CancelById(
       kPrivetNotificationID);
 }
 
 void PrivetNotificationService::Start() {
+#if defined(CHROMEOS)
+  SigninManagerBase* signin_manager =
+      SigninManagerFactory::GetForProfileIfExists(
+          Profile::FromBrowserContext(profile_));
+
+  if (!signin_manager || signin_manager->GetAuthenticatedUsername().empty())

[Vitaly Buka (NO REVIEWS), 2014/03/04 22:47:33]

I guess that's not enough.
service keeps running after sign off  of user, so it will show notification for
the next guest after that

[Noam Samuel, 2014/03/04 22:58:49]

Have we seen this behavior? I'd suspect notifications should only show on the
desktop of the profile's user, with the default profile being an exception to
that rule.

+    return;
+#endif
+
   enable_privet_notification_member_.Init(
       prefs::kLocalDiscoveryNotificationsEnabled,
       Profile::FromBrowserContext(profile_)->GetPrefs(),
       base::Bind(&PrivetNotificationService::OnNotificationsEnabledChanged,
                  base::Unretained(this)));
   OnNotificationsEnabledChanged();
 }
 
 void PrivetNotificationService::OnNotificationsEnabledChanged() {
   if (IsForced()) {
@@ skipping 82 matching lines @@
 
 void PrivetNotificationDelegate::DisableNotifications() {
   Profile* profile_obj = Profile::FromBrowserContext(profile_);
 
   profile_obj->GetPrefs()->SetBoolean(
       prefs::kLocalDiscoveryNotificationsEnabled,
       false);
 }
 
 }  // namespace local_discovery