Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1869783006: Revert of Pass policy VideoCaptureAllowed to ARC (Closed)

Created:
4 years, 8 months ago by phweiss
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tnagel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pass policy VideoCaptureAllowed to ARC (patchset #4 id:60001 of https://codereview.chromium.org/1864523002/ ) Reason for revert: Unit tests are failing, see https://bugs.chromium.org/p/chromium/issues/detail?id=601542 Original issue's description: > Fix syntax of JSON string, include cameraDisabled > > Instead of passing ArcApplicationPolicy as entry in the > json dictionary, it is now parsed and used as the top level > dictionary, with other policies added to it. The > VideoCaptureAllowed policy is mapped to cameraDisabled. > > Bug: b/25985338 > > Committed: https://crrev.com/e939d0314bc6ae82b04def09c58972ab121de51e > Cr-Commit-Position: refs/heads/master@{#385712} TBR=bartfab@chromium.org,lhchavez@chromium.org,nkostylev@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/77aeeb9fefc7e45ea0560f19848378a8e01d36b1 Cr-Commit-Position: refs/heads/master@{#385837}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -135 lines) Patch
M chrome/browser/chromeos/arc/arc_policy_bridge.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge.cc View 3 chunks +19 lines, -57 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc View 2 chunks +12 lines, -72 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
phweiss
Created Revert of Pass policy VideoCaptureAllowed to ARC
4 years, 8 months ago (2016-04-07 19:18:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869783006/1
4 years, 8 months ago (2016-04-07 19:19:36 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-07 19:19:39 UTC) #4
Luis Héctor Chávez
lgtm
4 years, 8 months ago (2016-04-07 19:25:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869783006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869783006/1
4 years, 8 months ago (2016-04-07 19:26:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 19:27:48 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 19:30:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77aeeb9fefc7e45ea0560f19848378a8e01d36b1
Cr-Commit-Position: refs/heads/master@{#385837}

Powered by Google App Engine
This is Rietveld 408576698