Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3769)

Unified Diff: chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc

Issue 1869783006: Revert of Pass policy VideoCaptureAllowed to ARC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/arc/arc_policy_bridge.cc ('k') | components/policy/resources/policy_templates.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc b/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
index 1574666db1aeaa9096f06fd710629b1c4cc9509e..ae0ead1da91c4bef64ee6c2eff39c2595fc46d83 100644
--- a/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include <memory>
-#include <string>
#include "base/macros.h"
#include "base/values.h"
@@ -69,81 +68,22 @@
DISALLOW_COPY_AND_ASSIGN(ArcPolicyBridgeTest);
};
-TEST_F(ArcPolicyBridgeTest, EmptyPolicyTest) {
- // No policy is set, result should be empty.
- policy_bridge()->GetPolicies(PolicyStringCallback("{}"));
-}
-
-TEST_F(ArcPolicyBridgeTest, ArcApplicationPolicyTest) {
+TEST_F(ArcPolicyBridgeTest, GetPoliciesTest) {
+ PolicyStringCallback empty_callback("{}");
+ policy_bridge()->GetPolicies(empty_callback);
+ policy_map().Set("HomepageLocation", policy::POLICY_LEVEL_MANDATORY,
+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
+ new base::StringValue("http://chromium.org"), nullptr);
+ policy_bridge()->GetPolicies(empty_callback);
policy_map().Set(
"ArcApplicationPolicy", policy::POLICY_LEVEL_MANDATORY,
policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::StringValue(
- "{\"applications\":"
- "[{\"packageName\":\"com.google.android.apps.youtube.kids\","
- "\"installType\":\"REQUIRED\","
- "\"lockTaskAllowed\":false,"
- "\"permissionGrants\":[]"
- "}],"
- "\"defaultPermissionPolicy\":\"GRANT\""
- "}"),
+ new base::StringValue("{\"application\": \"com.android.chrome\"}"),
nullptr);
- policy_bridge()->GetPolicies(PolicyStringCallback(
- "{\"applications\":"
- "[{\"installType\":\"REQUIRED\","
- "\"lockTaskAllowed\":false,"
- "\"packageName\":\"com.google.android.apps.youtube.kids\","
- "\"permissionGrants\":[]"
- "}],"
- "\"defaultPermissionPolicy\":\"GRANT\""
- "}"));
-}
-
-TEST_F(ArcPolicyBridgeTest, HompageLocationTest) {
- // This policy will not be passed on, result should be empty.
- policy_map().Set("HomepageLocation", policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::StringValue("http://chromium.org"), nullptr);
- policy_bridge()->GetPolicies(PolicyStringCallback("{}"));
-}
-
-TEST_F(ArcPolicyBridgeTest, VideoCaptureAllowedTest) {
- policy_map().Set("VideoCaptureAllowed", policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(false), nullptr);
- policy_bridge()->GetPolicies(
- PolicyStringCallback("{\"cameraDisabled\":true}"));
-}
-
-TEST_F(ArcPolicyBridgeTest, AllPoliciesTest) {
- // Keep them in alphabetical order.
- policy_map().Set(
- "ArcApplicationPolicy", policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::StringValue("{\"applications\":"
- "[{\"packageName\":\"com.google.android.apps.youtube.kids\","
- "\"installType\":\"REQUIRED\","
- "\"lockTaskAllowed\":false,"
- "\"permissionGrants\":[]"
- "}],"
- "\"defaultPermissionPolicy\":\"GRANT\"}"),
- nullptr);
- policy_map().Set("HomepageLocation", policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::StringValue("http://chromium.org"), nullptr);
- policy_map().Set("VideoCaptureAllowed", policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(false), nullptr);
- policy_bridge()->GetPolicies(PolicyStringCallback(
- "{\"applications\":"
- "[{\"installType\":\"REQUIRED\","
- "\"lockTaskAllowed\":false,"
- "\"packageName\":\"com.google.android.apps.youtube.kids\","
- "\"permissionGrants\":[]"
- "}],"
- "\"cameraDisabled\":true,"
- "\"defaultPermissionPolicy\":\"GRANT\""
- "}"));
+ PolicyStringCallback chrome_callback(
+ "{\"ArcApplicationPolicy\":"
+ "\"{\\\"application\\\": \\\"com.android.chrome\\\"}\"}");
+ policy_bridge()->GetPolicies(chrome_callback);
}
} // namespace arc
« no previous file with comments | « chrome/browser/chromeos/arc/arc_policy_bridge.cc ('k') | components/policy/resources/policy_templates.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698