Update LightingImageFilter to sk_sp

Update LightingImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1869763002

Committed: https://skia.googlesource.com/skia/+/12fa47d33f1e9eb69bb20d9daad2eccfc7288944

[robertphillips, 2016-04-07 13:49:58]

Description was changed from

==========
Update LightingImageFilter to sk_sp
==========

to

==========
Update LightingImageFilter to sk_sp
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 13:57:38]

Description was changed from

==========
Update LightingImageFilter to sk_sp
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update LightingImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-04-07 13:57:38]

robertphillips@google.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[robertphillips, 2016-04-07 14:41:21]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 14:41:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869763002/1

[commit-bot: I haz the power, 2016-04-07 14:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 14:57:21]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-08 17:37:28]

low-priority ping

[f(malita), 2016-04-08 21:12:09]

lgtm

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:354: : INHERITED(light, surfaceScale,
input, cropRect) {
nit: move light, input?

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1120: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
nit: move input

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1130: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
ditto

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1144: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
ditto

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1155: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
ditto

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1167: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
ditto

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1183: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
ditto

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1220: : INHERITED(light, surfaceScale,
input, cropRect)
nit: move light, input

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1362: : INHERITED(light, surfaceScale,
input, cropRect)
ditto

[robertphillips, 2016-04-08 21:56:53]

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:354: : INHERITED(light, surfaceScale,
input, cropRect) {
On 2016/04/08 21:12:08, f(malita) wrote:
> nit: move light, input?

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1120: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
On 2016/04/08 21:12:08, f(malita) wrote:
> nit: move input

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1130: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1144: return
SkDiffuseLightingImageFilter::Make(std::move(light), surfaceScale, kd, input,
cropRect);
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1155: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1167: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1183: return
SkSpecularLightingImageFilter::Make(std::move(light), surfaceScale, ks, shine,
input,
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1220: : INHERITED(light, surfaceScale,
input, cropRect)
On 2016/04/08 21:12:08, f(malita) wrote:
> nit: move light, input

Done.

https://codereview.chromium.org/1869763002/diff/1/src/effects/SkLightingImage...
src/effects/SkLightingImageFilter.cpp:1362: : INHERITED(light, surfaceScale,
input, cropRect)
On 2016/04/08 21:12:08, f(malita) wrote:
> ditto

Done.

[robertphillips, 2016-04-08 21:57:04]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-08 21:57:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869763002/20001

[commit-bot: I haz the power, 2016-04-08 22:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-08 22:18:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-08 23:27:07]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-08 23:27:07]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://codereview.chromium.org/1869763002/#ps20001
(title: "Address code review comments")

[commit-bot: I haz the power, 2016-04-08 23:27:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1869763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1869763002/20001

[commit-bot: I haz the power, 2016-04-08 23:28:12]

Description was changed from

==========
Update LightingImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Update LightingImageFilter to sk_sp

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/12fa47d33f1e9eb69bb20d9daad2eccfc7288944
==========

[commit-bot: I haz the power, 2016-04-08 23:28:12]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12fa47d33f1e9eb69bb20d9daad2eccfc7288944