Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: fuzz/FilterFuzz.cpp

Issue 1869763002: Update LightingImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address code review comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bench/LightingBench.cpp ('k') | gm/imagefiltersclipped.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fuzz/FilterFuzz.cpp
diff --git a/fuzz/FilterFuzz.cpp b/fuzz/FilterFuzz.cpp
index 1cd20c034e9ac33649a0468cd341faf6e6fa5baa..7c233b80bf8d9fc760f1a917657c84294f52cc82 100644
--- a/fuzz/FilterFuzz.cpp
+++ b/fuzz/FilterFuzz.cpp
@@ -626,52 +626,46 @@ static sk_sp<SkImageFilter> make_image_filter(bool canBeNull) {
case COMPOSE:
filter = SkComposeImageFilter::Make(make_image_filter(), make_image_filter());
break;
- case DISTANT_LIGHT: {
- sk_sp<SkImageFilter> subFilter(make_image_filter());
-
+ case DISTANT_LIGHT:
filter = (R(2) == 1)
- ? sk_sp<SkImageFilter>(SkLightingImageFilter::CreateDistantLitDiffuse(make_point(),
- make_color(), make_scalar(), make_scalar(),
- subFilter.get()))
- : sk_sp<SkImageFilter>(SkLightingImageFilter::CreateDistantLitSpecular(make_point(),
- make_color(), make_scalar(),
- make_scalar(), SkIntToScalar(R(10)),
- subFilter.get()));
+ ? SkLightingImageFilter::MakeDistantLitDiffuse(make_point(), make_color(),
+ make_scalar(), make_scalar(),
+ make_image_filter())
+ : SkLightingImageFilter::MakeDistantLitSpecular(make_point(), make_color(),
+ make_scalar(), make_scalar(),
+ SkIntToScalar(R(10)),
+ make_image_filter());
break;
- }
- case POINT_LIGHT: {
- sk_sp<SkImageFilter> subFilter(make_image_filter());
-
+ case POINT_LIGHT:
filter = (R(2) == 1)
- ? sk_sp<SkImageFilter>(SkLightingImageFilter::CreatePointLitDiffuse(make_point(),
- make_color(), make_scalar(), make_scalar(),
- subFilter.get()))
- : sk_sp<SkImageFilter>(SkLightingImageFilter::CreatePointLitSpecular(make_point(),
- make_color(), make_scalar(), make_scalar(),
- SkIntToScalar(R(10)),
- subFilter.get()));
+ ? SkLightingImageFilter::MakePointLitDiffuse(make_point(), make_color(),
+ make_scalar(), make_scalar(),
+ make_image_filter())
+ : SkLightingImageFilter::MakePointLitSpecular(make_point(), make_color(),
+ make_scalar(), make_scalar(),
+ SkIntToScalar(R(10)),
+ make_image_filter());
break;
- }
- case SPOT_LIGHT: {
- sk_sp<SkImageFilter> subFilter(make_image_filter());
-
+ case SPOT_LIGHT:
filter = (R(2) == 1)
- ? sk_sp<SkImageFilter>(SkLightingImageFilter::CreateSpotLitDiffuse(SkPoint3::Make(0, 0, 0),
- make_point(), make_scalar(), make_scalar(),
- make_color(), make_scalar(), make_scalar(),
- subFilter.get()))
- : sk_sp<SkImageFilter>(SkLightingImageFilter::CreateSpotLitSpecular(SkPoint3::Make(0, 0, 0),
- make_point(), make_scalar(), make_scalar(),
- make_color(), make_scalar(), make_scalar(),
- SkIntToScalar(R(10)), subFilter.get()));
+ ? SkLightingImageFilter::MakeSpotLitDiffuse(SkPoint3::Make(0, 0, 0),
+ make_point(), make_scalar(),
+ make_scalar(), make_color(),
+ make_scalar(), make_scalar(),
+ make_image_filter())
+ : SkLightingImageFilter::MakeSpotLitSpecular(SkPoint3::Make(0, 0, 0),
+ make_point(), make_scalar(),
+ make_scalar(), make_color(),
+ make_scalar(), make_scalar(),
+ SkIntToScalar(R(10)),
+ make_image_filter());
break;
- }
case NOISE: {
- sk_sp<SkShader> shader((R(2) == 1) ?
- SkPerlinNoiseShader::MakeFractalNoise(
- make_scalar(true), make_scalar(true), R(10.0f), make_scalar()) :
- SkPerlinNoiseShader::MakeTurbulence(
- make_scalar(true), make_scalar(true), R(10.0f), make_scalar()));
+ sk_sp<SkShader> shader((R(2) == 1)
+ ? SkPerlinNoiseShader::MakeFractalNoise(make_scalar(true), make_scalar(true),
+ R(10.0f), make_scalar())
+ : SkPerlinNoiseShader::MakeTurbulence(make_scalar(true), make_scalar(true),
+ R(10.0f), make_scalar()));
SkPaint paint;
paint.setShader(shader);
SkImageFilter::CropRect cropR(SkRect::MakeWH(SkIntToScalar(kBitmapSize),
« no previous file with comments | « bench/LightingBench.cpp ('k') | gm/imagefiltersclipped.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698