third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp - Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fmalita review - deconstify sk_sp<>s Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp b/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp

index 0c5de98b99a3e3217e189e97a0ef48e2d8ced306..76fda6df7695f63930b15709fbd16636d6c9c07a 100644

--- a/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CompositorFilterOperations.cpp

@@ -91,7 +91,7 @@ void CompositorFilterOperations::appendSaturatingBrightnessFilter(float amount)

void CompositorFilterOperations::appendReferenceFilter(SkImageFilter* imageFilter)

f(malita) 2016/04/21 15:45:47 Can we update the signature to sk_sp<SkImageFilter

tomhudson 2016/04/25 20:20:51 Done.

{

m_filterOperations.Append(

- cc::FilterOperation::CreateReferenceFilter(skia::SharePtr(imageFilter)));

+ cc::FilterOperation::CreateReferenceFilter(sk_ref_sp(imageFilter)));

}

void CompositorFilterOperations::clear()

« skia/ext/platform_canvas.h ('K') | « skia/ext/platform_canvas.cc ('k') | no next file » | no next file with comments »