skia/ext/platform_canvas.cc - Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/platform_canvas.cc

Issue 1869753003: Replace many skia::RefPtr with sk_sp<> in cc/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fmalita review - deconstify sk_sp<>s Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/platform_canvas.cc

diff --git a/skia/ext/platform_canvas.cc b/skia/ext/platform_canvas.cc

index dfd8e8f8a65128a004b7c489370475d407ef409d..0ff7d058159c2447881ed7a979da69ec307db135 100644

--- a/skia/ext/platform_canvas.cc

+++ b/skia/ext/platform_canvas.cc

@@ -69,7 +69,7 @@ size_t PlatformCanvasStrideForWidth(unsigned width) {

return 4 * width;

}

-SkCanvas* CreateCanvas(const sk_sp<SkBaseDevice>& device,

+SkCanvas* CreateCanvas(sk_sp<SkBaseDevice>& device,

OnFailureType failureType) {

if (!device) {

if (CRASH_ON_FAILURE == failureType)