Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1869723002: Make ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop font config independent (Closed)

Created:
4 years, 8 months ago by oshima
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop font config independent BUG=600404 R=jamescook@chromium.org Committed: https://crrev.com/e8c18394d174db7d105416a87115131a13e1bbb1 Cr-Commit-Position: refs/heads/master@{#385774}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
oshima
The status area size is font config dependent. I guess you have different font settings ...
4 years, 8 months ago (2016-04-07 10:49:57 UTC) #1
James Cook
LGTM nit: Update the CL description to mention which test this is. Thanks for fixing ...
4 years, 8 months ago (2016-04-07 15:27:09 UTC) #2
oshima
On 2016/04/07 15:27:09, James Cook wrote: > LGTM > > nit: Update the CL description ...
4 years, 8 months ago (2016-04-07 15:42:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869723002/1
4 years, 8 months ago (2016-04-07 15:42:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869723002/1
4 years, 8 months ago (2016-04-07 16:13:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 16:14:00 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:15:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8c18394d174db7d105416a87115131a13e1bbb1
Cr-Commit-Position: refs/heads/master@{#385774}

Powered by Google App Engine
This is Rietveld 408576698