Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: ash/shelf/shelf_layout_manager_unittest.cc

Issue 1869723002: Make ShelfLayoutManagerTest.ShelfLayoutInUnifiedDesktop font config independent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_layout_manager_unittest.cc
diff --git a/ash/shelf/shelf_layout_manager_unittest.cc b/ash/shelf/shelf_layout_manager_unittest.cc
index 91d34cb478810ffbdb192687ce7dca1e0693913f..870396321395e06fd6098751ad954851c4f25682 100644
--- a/ash/shelf/shelf_layout_manager_unittest.cc
+++ b/ash/shelf/shelf_layout_manager_unittest.cc
@@ -2325,15 +2325,15 @@ TEST_F(ShelfLayoutManagerTest, ShelfLayoutInUnifiedDesktop) {
return;
Shell::GetInstance()->display_manager()->SetUnifiedDesktopEnabled(true);
- UpdateDisplay("500x500, 500x500");
+ UpdateDisplay("500x400, 500x400");
James Cook 2016/04/07 15:27:09 Hooray for different width and height!
StatusAreaWidget* status_area_widget =
Shell::GetPrimaryRootWindowController()->shelf()->status_area_widget();
EXPECT_TRUE(status_area_widget->IsVisible());
// Shelf should be in the first display's area.
- // TODO: make this test more robust against changes in font, font size.
- EXPECT_EQ("353,453 147x47",
- status_area_widget->GetWindowBoundsInScreen().ToString());
+ gfx::Rect status_area_bounds(status_area_widget->GetWindowBoundsInScreen());
+ EXPECT_TRUE(gfx::Rect(0, 0, 500, 400).Contains(status_area_bounds));
+ EXPECT_EQ(gfx::Point(500, 400), status_area_bounds.bottom_right());
}
} // namespace ash
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698