chrome/browser/themes/theme_service.h - Issue 1869693002: Theme suppliers: Avoid all Image copying.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/theme_service.h

Issue 1869693002: Theme suppliers: Avoid all Image copying. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/theme_service.h

diff --git a/chrome/browser/themes/theme_service.h b/chrome/browser/themes/theme_service.h

index d8e02262b2cd2f37e4adc6f59b65403a0894882e..7c88b9f8ea7bb511ce7940c94e6d8fef1131f9ce 100644

--- a/chrome/browser/themes/theme_service.h

+++ b/chrome/browser/themes/theme_service.h

@@ -249,7 +249,7 @@ class ThemeService : public base::NonThreadSafe,

// TODO(erg): Make this part of the ui::ThemeProvider and the main way to get

// theme properties out of the theme provider since it's cross platform.

- gfx::Image GetImageNamed(int id, bool incognito) const;

+ const gfx::Image& GetImageNamed(int id, bool incognito) const;

// Called when the extension service is ready.

void OnExtensionServiceReady();