Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: chrome/browser/themes/theme_service.h

Issue 1869693002: Theme suppliers: Avoid all Image copying. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/themes/custom_theme_supplier.cc ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_THEMES_THEME_SERVICE_H_ 5 #ifndef CHROME_BROWSER_THEMES_THEME_SERVICE_H_
6 #define CHROME_BROWSER_THEMES_THEME_SERVICE_H_ 6 #define CHROME_BROWSER_THEMES_THEME_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 bool HasCustomColor(int id) const; 242 bool HasCustomColor(int id) const;
243 NSColor* GetNSColor(int id, bool incognito) const; 243 NSColor* GetNSColor(int id, bool incognito) const;
244 NSColor* GetNSColorTint(int id) const; 244 NSColor* GetNSColorTint(int id) const;
245 NSGradient* GetNSGradient(int id) const; 245 NSGradient* GetNSGradient(int id) const;
246 #endif 246 #endif
247 247
248 // Returns a cross platform image for an id. 248 // Returns a cross platform image for an id.
249 // 249 //
250 // TODO(erg): Make this part of the ui::ThemeProvider and the main way to get 250 // TODO(erg): Make this part of the ui::ThemeProvider and the main way to get
251 // theme properties out of the theme provider since it's cross platform. 251 // theme properties out of the theme provider since it's cross platform.
252 gfx::Image GetImageNamed(int id, bool incognito) const; 252 const gfx::Image& GetImageNamed(int id, bool incognito) const;
253 253
254 // Called when the extension service is ready. 254 // Called when the extension service is ready.
255 void OnExtensionServiceReady(); 255 void OnExtensionServiceReady();
256 256
257 // Migrate the theme to the new theme pack schema by recreating the data pack 257 // Migrate the theme to the new theme pack schema by recreating the data pack
258 // from the extension. 258 // from the extension.
259 void MigrateTheme(); 259 void MigrateTheme();
260 260
261 // Replaces the current theme supplier with a new one and calls 261 // Replaces the current theme supplier with a new one and calls
262 // StopUsingTheme() or StartUsingTheme() as appropriate. 262 // StopUsingTheme() or StartUsingTheme() as appropriate.
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 324
325 BrowserThemeProvider original_theme_provider_; 325 BrowserThemeProvider original_theme_provider_;
326 BrowserThemeProvider incognito_theme_provider_; 326 BrowserThemeProvider incognito_theme_provider_;
327 327
328 base::WeakPtrFactory<ThemeService> weak_ptr_factory_; 328 base::WeakPtrFactory<ThemeService> weak_ptr_factory_;
329 329
330 DISALLOW_COPY_AND_ASSIGN(ThemeService); 330 DISALLOW_COPY_AND_ASSIGN(ThemeService);
331 }; 331 };
332 332
333 #endif // CHROME_BROWSER_THEMES_THEME_SERVICE_H_ 333 #endif // CHROME_BROWSER_THEMES_THEME_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/themes/custom_theme_supplier.cc ('k') | chrome/browser/themes/theme_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698