Add internal fields to JSArrayBufferViews (JSTypedArray and JSDataView)

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 3afb83572a903e690e377c2b8bce5f900e60404d..caaa5c255cdb812aa75ee7ee4cef22b32d244f2c 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2489,6 +2489,11 @@ class V8EXPORT ArrayBuffer : public Object {
 };
 
 
+#ifndef V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT

[titzer, 2013/07/05 08:09:57]

I'm not sure why you conditionally define a macro here. Is the macro potentially
defined somewhere else (maybe with a -D for testing?) If so, it would be nice to
have a sentence explaining why.

[Dmitry Lomov (no reviews), 2013/07/05 09:56:02]

The number of these external fields can vary from embedder to embedder. I chose
2 as a convenient default for Blink.
Added comment to that effect.

+#define V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT 2
+#endif
+
+
 /**
  * A base class for an instance of one of "views" over ArrayBuffer,
  * including TypedArrays and DataView (ES6 draft 15.13).
@@ -2516,6 +2521,9 @@ class V8EXPORT ArrayBufferView : public Object {
 
   V8_INLINE(static ArrayBufferView* Cast(Value* obj));
 
+  static const int kInternalFieldCount =
+      V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT;

[titzer, 2013/07/05 08:09:57]

BTW, where are these internal fields defined?

[Dmitry Lomov (no reviews), 2013/07/05 09:56:02]

I am not sure what the question is (the rest of the patch defines the fields,
adding them to JSTypedArray and JSArrayBufferView). These fields are accessed by
the embedder, we do not know what they are, we just provide space.

+
  private:
   ArrayBufferView();
   static void CheckCast(Value* obj);