Add internal fields to JSArrayBufferViews (JSTypedArray and JSDataView)

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2471 matching lines @@
   V8_INLINE(static ArrayBuffer* Cast(Value* obj));
 
   static const int kInternalFieldCount = V8_ARRAY_BUFFER_INTERNAL_FIELD_COUNT;
 
  private:
   ArrayBuffer();
   static void CheckCast(Value* obj);
 };
 
 
+#ifndef V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT

[titzer, 2013/07/05 08:09:57]

I'm not sure why you conditionally define a macro here. Is the macro potentially
defined somewhere else (maybe with a -D for testing?) If so, it would be nice to
have a sentence explaining why.

[Dmitry Lomov (no reviews), 2013/07/05 09:56:02]

The number of these external fields can vary from embedder to embedder. I chose
2 as a convenient default for Blink.
Added comment to that effect.

+#define V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT 2
+#endif
+
+
 /**
  * A base class for an instance of one of "views" over ArrayBuffer,
  * including TypedArrays and DataView (ES6 draft 15.13).
  *
  * This API is experimental and may change significantly.
  */
 class V8EXPORT ArrayBufferView : public Object {
  public:
   /**
    * Returns underlying ArrayBuffer.
    */
   Local<ArrayBuffer> Buffer();
   /**
    * Byte offset in |Buffer|.
    */
   size_t ByteOffset();
   /**
    * Size of a view in bytes.
    */
   size_t ByteLength();
   /**
    * Base address of a view.
    */
   void* BaseAddress();
 
   V8_INLINE(static ArrayBufferView* Cast(Value* obj));
 
+  static const int kInternalFieldCount =
+      V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT;

[titzer, 2013/07/05 08:09:57]

BTW, where are these internal fields defined?

[Dmitry Lomov (no reviews), 2013/07/05 09:56:02]

I am not sure what the question is (the rest of the patch defines the fields,
adding them to JSTypedArray and JSArrayBufferView). These fields are accessed by
the embedder, we do not know what they are, we just provide space.

+
  private:
   ArrayBufferView();
   static void CheckCast(Value* obj);
 };
 
 
 /**
  * A base class for an instance of TypedArray series of constructors
  * (ES6 draft 15.13.6).
  * This API is experimental and may change significantly.
@@ skipping 3936 matching lines @@
 
 
 }  // namespace v8
 
 
 #undef V8EXPORT
 #undef TYPE_CHECK
 
 
 #endif  // V8_H_