Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1869453002: Fix Gyp rule that broke node.js build after snapshot log removal. (Closed)

Created:
4 years, 8 months ago by Stefano Sanfilippo
Modified:
4 years, 8 months ago
CC:
rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Gyp rule that broke node.js build after snapshot log removal. LOG=N Committed: https://crrev.com/2f8de2e80a781c17bfad5aed14ed937dc082c6ac Cr-Commit-Position: refs/heads/master@{#35328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Stefano Sanfilippo
As in the object. I am not entirely sure that using an empty list is ...
4 years, 8 months ago (2016-04-06 15:07:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869453002/1
4 years, 8 months ago (2016-04-06 15:07:58 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 15:28:49 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-07 03:44:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869453002/1
4 years, 8 months ago (2016-04-07 09:10:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 09:12:10 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 09:13:13 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2f8de2e80a781c17bfad5aed14ed937dc082c6ac
Cr-Commit-Position: refs/heads/master@{#35328}

Powered by Google App Engine
This is Rietveld 408576698