tools/gyp/v8.gyp - Issue 1869453002: Fix Gyp rule that broke node.js build after snapshot log removal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/v8.gyp

Issue 1869453002: Fix Gyp rule that broke node.js build after snapshot log removal. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gyp/v8.gyp

diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp

index 280388fc77325a66c65952acc2c33c99e8eb3fb1..1cfdc5f79f7ebba0bd68eabf0d4ba28748431a3f 100644

--- a/tools/gyp/v8.gyp

+++ b/tools/gyp/v8.gyp

@@ -211,6 +211,7 @@

'<(INTERMEDIATE_DIR)/snapshot.cc',

'variables': {

+ 'mksnapshot_flags': [],

'conditions': [

['v8_random_seed!=0', {

'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],

@@ -370,6 +371,7 @@

'action_name': 'run_mksnapshot (external)',

'inputs': ['<(mksnapshot_exec)'],

'variables': {

+ 'mksnapshot_flags': [],

'conditions': [

['v8_random_seed!=0', {

'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],

« no previous file with comments | « no previous file | no next file » | no next file with comments »