Issue 1869443003: Always delete old_chrome.exe last in the rename dance since it cannot be rolled back.

Issue 1869443003: Always delete old_chrome.exe last in the rename dance since it cannot be rolled back. (Closed)

Created:
4 years, 8 months ago by grt (UTC plus 2)

Modified:
4 years, 8 months ago

Reviewers:
fdoray, grt (UTC plus 2)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Always delete old_chrome.exe last in the rename dance since it cannot be rolled back. BUG=596636 R=fdoray@chromium.org Review URL: https://codereview.chromium.org/1864663002 Cr-Commit-Position: refs/heads/master@{#385294} (cherry picked from commit e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc) TBR=grt@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/08b5f1efaecb99db99b2ee8b3ad9cf76c67c2f46

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	chrome/installer/setup/setup_main.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 4 (3 generated)

grt (UTC plus 2)

4 years, 8 months ago (2016-04-07 00:46:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
08b5f1efaecb99db99b2ee8b3ad9cf76c67c2f46.