Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1864663002: Always delete old_chrome.exe last in the rename dance since it cannot be rolled back. (Closed)

Created:
4 years, 8 months ago by grt (UTC plus 2)
Modified:
4 years, 8 months ago
Reviewers:
fdoray
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always delete old_chrome.exe last in the rename dance since it cannot be rolled back. BUG=596636 R=fdoray@chromium.org Committed: https://crrev.com/e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc Cr-Commit-Position: refs/heads/master@{#385294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/installer/setup/setup_main.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864663002/1
4 years, 8 months ago (2016-04-05 18:40:59 UTC) #2
grt (UTC plus 2)
PTAL. Although you're working on a more correct fix for this, I think we need ...
4 years, 8 months ago (2016-04-05 18:41:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 19:30:42 UTC) #5
fdoray
lgtm
4 years, 8 months ago (2016-04-05 20:21:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864663002/1
4 years, 8 months ago (2016-04-05 21:58:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 22:05:31 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 22:08:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e1fe3afddbb41f46ef57e226f6f8ae1855dd9dfc
Cr-Commit-Position: refs/heads/master@{#385294}

Powered by Google App Engine
This is Rietveld 408576698