Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/base/logging.h

Issue 1869433004: Fix printf formats (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/base/format-macros.h ('k') | src/base/macros.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_BASE_LOGGING_H_ 5 #ifndef V8_BASE_LOGGING_H_
6 #define V8_BASE_LOGGING_H_ 6 #define V8_BASE_LOGGING_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <sstream> 9 #include <sstream>
10 #include <string> 10 #include <string>
11 11
12 #include "src/base/build_config.h" 12 #include "src/base/build_config.h"
13 #include "src/base/compiler-specific.h"
13 14
14 extern "C" V8_NORETURN void V8_Fatal(const char* file, int line, 15 extern "C" PRINTF_FORMAT(3, 4) V8_NORETURN
15 const char* format, ...); 16 void V8_Fatal(const char* file, int line, const char* format, ...);
16 17
17 extern "C" void V8_RuntimeError(const char* file, int line, 18 extern "C" void V8_RuntimeError(const char* file, int line,
18 const char* message); 19 const char* message);
19 20
20 // The FATAL, UNREACHABLE and UNIMPLEMENTED macros are useful during 21 // The FATAL, UNREACHABLE and UNIMPLEMENTED macros are useful during
21 // development, but they should not be relied on in the final product. 22 // development, but they should not be relied on in the final product.
22 #ifdef DEBUG 23 #ifdef DEBUG
23 #define FATAL(msg) \ 24 #define FATAL(msg) \
24 V8_Fatal(__FILE__, __LINE__, "%s", (msg)) 25 V8_Fatal(__FILE__, __LINE__, "%s", (msg))
25 #define UNIMPLEMENTED() \ 26 #define UNIMPLEMENTED() \
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 #define DCHECK_GT(v1, v2) ((void) 0) 171 #define DCHECK_GT(v1, v2) ((void) 0)
171 #define DCHECK_GE(v1, v2) ((void) 0) 172 #define DCHECK_GE(v1, v2) ((void) 0)
172 #define DCHECK_LT(v1, v2) ((void) 0) 173 #define DCHECK_LT(v1, v2) ((void) 0)
173 #define DCHECK_LE(v1, v2) ((void) 0) 174 #define DCHECK_LE(v1, v2) ((void) 0)
174 #define DCHECK_NULL(val) ((void) 0) 175 #define DCHECK_NULL(val) ((void) 0)
175 #define DCHECK_NOT_NULL(val) ((void) 0) 176 #define DCHECK_NOT_NULL(val) ((void) 0)
176 #define DCHECK_IMPLIES(v1, v2) ((void) 0) 177 #define DCHECK_IMPLIES(v1, v2) ((void) 0)
177 #endif 178 #endif
178 179
179 #endif // V8_BASE_LOGGING_H_ 180 #endif // V8_BASE_LOGGING_H_
OLDNEW
« no previous file with comments | « src/base/format-macros.h ('k') | src/base/macros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698