Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4481)

Unified Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

Issue 1869163003: Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: opaque edits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/opaque_browser_frame_view.h
diff --git a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
index e70e8b4ede79d2c9f6a9f2158a3ca52241c2f317..49d20af02c54d32a03a1ca176806c8e67c06a201 100644
--- a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
+++ b/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
@@ -126,8 +126,9 @@ class OpaqueBrowserFrameView : public BrowserNonClientFrameView,
// Returns true if the specified point is within the avatar menu buttons.
bool IsWithinAvatarMenuButtons(const gfx::Point& point) const;
- // Returns the thickness of the entire nonclient left, right, and bottom
- // borders, including both the window frame and any client edge.
+ // Returns the thickness of the entire nonclient left, right, top, and bottom
+ // borders, including both the window frame and any client edge, but excluding
+ // the titlebar/tabstrip area.
Peter Kasting 2016/04/15 00:20:52 Now I'm really confused -- I don't know what "the
Bret 2016/04/15 23:07:08 Hmmm okay you're right, this was the same mistake
int NonClientBorderThickness() const;
// Returns the bounds of the titlebar icon (or where the icon would be if

Powered by Google App Engine
This is Rietveld 408576698