Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/ui/views/frame/opaque_browser_frame_view.h

Issue 1869163003: Refactored GlassBrowserFrameView and BrowserDesktopTreeHostWin. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: opaque edits Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/ui/view_ids.h" 10 #include "chrome/browser/ui/view_ids.h"
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 ViewID view_id); 119 ViewID view_id);
120 120
121 // Returns the thickness of the border that makes up the window frame edges. 121 // Returns the thickness of the border that makes up the window frame edges.
122 // This does not include any client edge. If |restored| is true, this is 122 // This does not include any client edge. If |restored| is true, this is
123 // calculated as if the window was restored, regardless of its current state. 123 // calculated as if the window was restored, regardless of its current state.
124 int FrameBorderThickness(bool restored) const; 124 int FrameBorderThickness(bool restored) const;
125 125
126 // Returns true if the specified point is within the avatar menu buttons. 126 // Returns true if the specified point is within the avatar menu buttons.
127 bool IsWithinAvatarMenuButtons(const gfx::Point& point) const; 127 bool IsWithinAvatarMenuButtons(const gfx::Point& point) const;
128 128
129 // Returns the thickness of the entire nonclient left, right, and bottom 129 // Returns the thickness of the entire nonclient left, right, top, and bottom
130 // borders, including both the window frame and any client edge. 130 // borders, including both the window frame and any client edge, but excluding
131 // the titlebar/tabstrip area.
Peter Kasting 2016/04/15 00:20:52 Now I'm really confused -- I don't know what "the
Bret 2016/04/15 23:07:08 Hmmm okay you're right, this was the same mistake
131 int NonClientBorderThickness() const; 132 int NonClientBorderThickness() const;
132 133
133 // Returns the bounds of the titlebar icon (or where the icon would be if 134 // Returns the bounds of the titlebar icon (or where the icon would be if
134 // there was one). 135 // there was one).
135 gfx::Rect IconBounds() const; 136 gfx::Rect IconBounds() const;
136 137
137 // Returns true if the view should draw its own custom title bar. 138 // Returns true if the view should draw its own custom title bar.
138 bool ShouldShowWindowTitleBar() const; 139 bool ShouldShowWindowTitleBar() const;
139 140
140 // Computes the height of the top area of the frame. 141 // Computes the height of the top area of the frame.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 // Background painter for the window frame. 175 // Background painter for the window frame.
175 scoped_ptr<views::FrameBackground> frame_background_; 176 scoped_ptr<views::FrameBackground> frame_background_;
176 177
177 // Observer that handles platform dependent configuration. 178 // Observer that handles platform dependent configuration.
178 scoped_ptr<OpaqueBrowserFrameViewPlatformSpecific> platform_observer_; 179 scoped_ptr<OpaqueBrowserFrameViewPlatformSpecific> platform_observer_;
179 180
180 DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameView); 181 DISALLOW_COPY_AND_ASSIGN(OpaqueBrowserFrameView);
181 }; 182 };
182 183
183 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_ 184 #endif // CHROME_BROWSER_UI_VIEWS_FRAME_OPAQUE_BROWSER_FRAME_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698