Issue 186903003: Merge 254314 "Fix race condition in uploading feedback reports."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186903003: Merge 254314 "Fix race condition in uploading feedback reports." (Closed)

Created:
6 years, 9 months ago by rkc

Modified:
6 years, 9 months ago

Reviewers:
rkc

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/branches/1847/src/

Visibility:
Public.

More Reviews

Description

Merge 254314 "Fix race condition in uploading feedback reports." > Fix race condition in uploading feedback reports. > It is possible that if the browser starts and shuts down really quickly, we may end up with a race where the context passed to LoadReports has been nullified. We can completely avoid this race by simply passing in the user directory to LoadReportsAndQueue since the method doesn't really need the context for anything else. > > R=zork@chromium.org > BUG=345805 > > Review URL: https://codereview.chromium.org/185003005 TBR=rkc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254799

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	chrome/browser/feedback/feedback_profile_observer.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/feedback/feedback_report.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/feedback/feedback_report.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/browser/feedback/feedback_uploader.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r254799.

Expand Messages | Collapse Messages