Fix race condition in uploading feedback reports.

Fix race condition in uploading feedback reports.
It is possible that if the browser starts and shuts down really quickly, we may end up with a race where the context passed to LoadReports has been nullified. We can completely avoid this race by simply passing in the user directory to LoadReportsAndQueue since the method doesn't really need the context for anything else.

R=zork@chromium.org
BUG=345805
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254314

[Vitaly Buka (NO REVIEWS), 2014-02-28 22:39:10]

lgtm

https://codereview.chromium.org/185003005/diff/1/chrome/browser/feedback/feed...
File chrome/browser/feedback/feedback_profile_observer.cc (right):

https://codereview.chromium.org/185003005/diff/1/chrome/browser/feedback/feed...
chrome/browser/feedback/feedback_profile_observer.cc:55: base::Bind(
Maybe this ways is better?

BrowserThread::PostBlockingPoolTask(
    FROM_HERE,
    base::Bind(&FeedbackReport::LoadReportsAndQueue,
               context->GetPath(),
               base::Bind(&FeedbackUploader::QueueReport,
                          uploader->AsWeakPtr())));

[rkc, 2014-02-28 22:41:21]

https://codereview.chromium.org/185003005/diff/1/chrome/browser/feedback/feed...
File chrome/browser/feedback/feedback_profile_observer.cc (right):

https://codereview.chromium.org/185003005/diff/1/chrome/browser/feedback/feed...
chrome/browser/feedback/feedback_profile_observer.cc:55: base::Bind(
On 2014/02/28 22:39:10, Vitaly Buka wrote:
> Maybe this ways is better?
> 
> BrowserThread::PostBlockingPoolTask(
>     FROM_HERE,
>     base::Bind(&FeedbackReport::LoadReportsAndQueue,
>                context->GetPath(),
>                base::Bind(&FeedbackUploader::QueueReport,
>                           uploader->AsWeakPtr())));

Done.

[rkc, 2014-02-28 22:52:00]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2014-02-28 22:54:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/185003005/20001

[commit-bot: I haz the power, 2014-03-01 01:07:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/185003005/20001

[commit-bot: I haz the power, 2014-03-01 01:29:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rkc@chromium.org/185003005/20001

[commit-bot: I haz the power, 2014-03-01 01:41:05]

Change committed as 254314