Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1869013002: Avoid IndexedDBClient::create() read race. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid IndexedDBClient::create() read race. R=haraken BUG=598551 Committed: https://crrev.com/7f906f7d164fd89132d1ea261d83e09df9e508f6 Cr-Commit-Position: refs/heads/master@{#385772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look. I really should have spotted & handled this dual read race ...
4 years, 8 months ago (2016-04-07 14:07:00 UTC) #2
sof
sorry, please wait for now - I think there's more synchronization needed here.
4 years, 8 months ago (2016-04-07 14:12:22 UTC) #3
sof
On 2016/04/07 14:12:22, sof wrote: > sorry, please wait for now - I think there's ...
4 years, 8 months ago (2016-04-07 14:53:27 UTC) #4
haraken
LGTM
4 years, 8 months ago (2016-04-07 15:28:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869013002/1
4 years, 8 months ago (2016-04-07 15:57:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 16:03:12 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:04:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f906f7d164fd89132d1ea261d83e09df9e508f6
Cr-Commit-Position: refs/heads/master@{#385772}

Powered by Google App Engine
This is Rietveld 408576698