Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1862403002: Avoid setIndexedDBClientCreateFunction() write race. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid setIndexedDBClientCreateFunction() write race. R=haraken BUG=599011 Committed: https://crrev.com/5723b5345281cbc8d3cbe7d4715003a2ee206edd Cr-Commit-Position: refs/heads/master@{#385733}

Patch Set 1 #

Patch Set 2 : reduce reinterpret_cast<> casting #

Patch Set 3 : fix assert condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp View 1 2 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-07 11:58:33 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-07 12:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1862403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1862403002/40001
4 years, 8 months ago (2016-04-07 12:15:01 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 13:14:35 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 13:16:58 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5723b5345281cbc8d3cbe7d4715003a2ee206edd
Cr-Commit-Position: refs/heads/master@{#385733}

Powered by Google App Engine
This is Rietveld 408576698