[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan.

[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}

Committed: https://crrev.com/02ccb0417b5c109e1883f12f81798b1a0f4d9c6e
Cr-Commit-Position: refs/heads/master@{#35411}

[Benedikt Meurer, 2016-04-07 11:19:17]

Hey Enrico,

This migrates two problematic users of %_String intrinsics, which yields a nice
improvement with TurboFan and Ignition.
Can you please take a look?

Thanks,
Benedikt

[epertoso, 2016-04-07 14:31:10]

https://codereview.chromium.org/1868963002/diff/1/src/compiler/code-stub-asse...
File src/compiler/code-stub-assembler.cc (right):

https://codereview.chromium.org/1868963002/diff/1/src/compiler/code-stub-asse...
src/compiler/code-stub-assembler.cc:1267: // Allocate a new SeqTwoByteString for
{code}.
Is this correct? There's an entry in the cache in this case.

[Benedikt Meurer, 2016-04-08 04:18:42]

https://codereview.chromium.org/1868963002/diff/1/src/compiler/code-stub-asse...
File src/compiler/code-stub-assembler.cc (right):

https://codereview.chromium.org/1868963002/diff/1/src/compiler/code-stub-asse...
src/compiler/code-stub-assembler.cc:1267: // Allocate a new SeqTwoByteString for
{code}.
Ah, damn copy&paste. It should use the entry obviously and this should be in
if_codeistwobyte :-)

[epertoso, 2016-04-08 08:27:04]

lgtm

[Benedikt Meurer, 2016-04-08 10:18:40]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-04-08 10:18:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868963002/20001

[commit-bot: I haz the power, 2016-04-08 10:20:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-08 10:21:45]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

R=epertoso@chromium.org
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

[commit-bot: I haz the power, 2016-04-08 10:21:45]

Patchset 2 (id:??) landed as
https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

[Michael Hablich, 2016-04-08 11:24:05]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1870993002/ by hablich@chromium.org.

The reason for reverting is: Needed to revert
https://codereview.chromium.org/1838283003/.

[Benedikt Meurer, 2016-04-12 06:57:34]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

[Benedikt Meurer, 2016-04-12 06:58:53]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

[Benedikt Meurer, 2016-04-12 06:59:01]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-12 06:59:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868963002/40001

[Benedikt Meurer, 2016-04-12 07:01:38]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-04-12 07:01:54]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-04-12 07:01:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1868963002/#ps40001
(title: "REBASE")

[commit-bot: I haz the power, 2016-04-12 07:02:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868963002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868963002/40001

[commit-bot: I haz the power, 2016-04-12 07:50:38]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

[commit-bot: I haz the power, 2016-04-12 07:50:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 07:51:28]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

[commit-bot: I haz the power, 2016-04-12 07:51:29]

Patchset 3 (id:??) landed as
https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}

[Michael Achenbach, 2016-04-12 09:43:43]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1877263002/ by machenbach@chromium.org.

The reason for reverting is: Please rebaseline:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Benedikt Meurer, 2016-04-12 09:47:35]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

[Benedikt Meurer, 2016-04-12 09:51:05]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

[Benedikt Meurer, 2016-04-12 09:51:36]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-04-12 09:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org
Link to the patchset: https://codereview.chromium.org/1868963002/#ps60001
(title: "Fix typo")

[commit-bot: I haz the power, 2016-04-12 09:51:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868963002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868963002/60001

[commit-bot: I haz the power, 2016-04-12 10:29:57]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

[commit-bot: I haz the power, 2016-04-12 10:29:58]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-12 10:31:35]

Description was changed from

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}
==========

to

==========
[builtins] Migrate String.prototype.charCodeAt and String.prototype.charAt to
TurboFan.

Make these builtins fast by default w/o relying on the
%_StringCharCodeAt and %_StringCharAt intrinsics, which we cannot deal
with well in TurboFan (and ignition).

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_dbg,v8_linux_blink_rel
R=epertoso@chromium.org

Committed: https://crrev.com/43d3331d87f68ea7efa1b58f559f33f60e5dacfb
Cr-Commit-Position: refs/heads/master@{#35350}

Committed: https://crrev.com/253a16f690ab593a95249c34ded9df477ad9a54c
Cr-Commit-Position: refs/heads/master@{#35402}

Committed: https://crrev.com/02ccb0417b5c109e1883f12f81798b1a0f4d9c6e
Cr-Commit-Position: refs/heads/master@{#35411}
==========

[commit-bot: I haz the power, 2016-04-12 10:31:36]

Patchset 4 (id:??) landed as
https://crrev.com/02ccb0417b5c109e1883f12f81798b1a0f4d9c6e
Cr-Commit-Position: refs/heads/master@{#35411}

[Igor Sheludko, 2016-09-28 16:00:22]

ishell@chromium.org changed reviewers:
+ ishell@chromium.org

[Igor Sheludko, 2016-09-28 16:00:23]

https://codereview.chromium.org/1868963002/diff/60001/src/compiler/code-stub-...
File src/compiler/code-stub-assembler.cc (right):

https://codereview.chromium.org/1868963002/diff/60001/src/compiler/code-stub-...
src/compiler/code-stub-assembler.cc:1162: &if_stringisshort,
&if_stringisnotshort);
DBC: These label names are not in sync with the shortness definition (see
ExternalString::is_short()).