Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1868933004: Revert of For *ToFixed, in debug mode, assert that the value is in range. (Closed)

Created:
4 years, 8 months ago by fmalita_google_do_not_use
Modified:
4 years, 8 months ago
Reviewers:
dogben, mtklein, reed1
CC:
f(malita), jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@scalar-pin-to-fixed
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of For *ToFixed, in debug mode, assert that the value is in range. (patchset #6 id:140001 of https://codereview.chromium.org/1824733002/ ) Reason for revert: Asserts in Blink rolls: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/84520/layout-test-results/results.html STDERR: [1:1:0407/120919:1455366829:INFO:SkFixed.h(88)] ../../third_party/skia/include/private/SkFixed.h:88: fatal error: ""truncf(x * (1 << 16)) == static_cast<float> Original issue's description: > For *ToFixed, in debug mode, assert that the value is in range. > > Use SkFloatPinToFixed in SkTwoPointConicalGradient.cpp because it is failing in DM. fmalita is working on replacing this code with the 4f version, so I'm not bothering to fix it. (The beginnings of a real fix are in https://codereview.chromium.org/1767163003, which I do not plan to commit.) > > BUG=skia:4632 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1824733002 > > Committed: https://skia.googlesource.com/skia/+/93dc33972cd6a418e84270298b856d2de08d9c1c TBR=mtklein@google.com,reed@google.com,benjaminwagner@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4632 Committed: https://skia.googlesource.com/skia/+/e7365065acfe1fc6abbeb248fd5cc0ca83d9d341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -78 lines) Patch
M include/private/SkFixed.h View 4 chunks +68 lines, -76 lines 0 comments Download
M src/core/SkScan.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
fmalita_google_do_not_use
Created Revert of For *ToFixed, in debug mode, assert that the value is in range.
4 years, 8 months ago (2016-04-08 02:27:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868933004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868933004/1
4 years, 8 months ago (2016-04-08 02:27:39 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 02:27:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e7365065acfe1fc6abbeb248fd5cc0ca83d9d341

Powered by Google App Engine
This is Rietveld 408576698