Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1767163003: Use float rather than SkFixed for gradient TileProcs. (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@scalar-pin-to-fixed
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use float rather than SkFixed for gradient TileProcs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1767163003

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -160 lines) Patch
M include/core/SkScalar.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/effects/gradients/SkClampRange.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/effects/gradients/SkClampRange.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 1 2 3 4 chunks +27 lines, -8 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 10 chunks +28 lines, -22 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 3 7 chunks +11 lines, -9 lines 0 comments Download
D tests/ClampRangeTest.cpp View 1 2 1 chunk +0 lines, -108 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767163003/1
4 years, 9 months ago (2016-03-08 03:13:07 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/989)
4 years, 9 months ago (2016-03-08 03:14:17 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767163003/20001
4 years, 9 months ago (2016-03-08 03:18:57 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/990)
4 years, 9 months ago (2016-03-08 03:20:07 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767163003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767163003/40001
4 years, 9 months ago (2016-03-08 16:17:50 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6928) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 9 months ago (2016-03-08 16:21:21 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767163003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767163003/60001
4 years, 9 months ago (2016-03-08 16:39:20 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 16:51:48 UTC) #17 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698