runtime/vm/guard_field_test.cc - Issue 1868803002: Use symbols when looking up fields in a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/guard_field_test.cc

Issue 1868803002: Use symbols when looking up fields in a class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/guard_field_test.cc

diff --git a/runtime/vm/guard_field_test.cc b/runtime/vm/guard_field_test.cc

index d0ecb6edf503725ef0ea6bfbe9ed4d26b8fb3486..fcefc692b6a44704ca00d2f8661e83af57790baa 100644

--- a/runtime/vm/guard_field_test.cc

+++ b/runtime/vm/guard_field_test.cc

@@ -18,7 +18,8 @@ RawField* LookupField(Dart_Handle library, const char* class_name,

EXPECT(!cls.IsNull()); // No ambiguity error expected.

String& fieldname = String::Handle(String::New(field_name));

- Field& field = Field::ZoneHandle(cls.LookupInstanceField(fieldname));

+ Field& field =

+ Field::ZoneHandle(cls.LookupInstanceFieldAllowPrivate(fieldname));

EXPECT(!field.IsNull());

return field.raw();

}