runtime/vm/exceptions.cc - Issue 1868803002: Use symbols when looking up fields in a class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 1868803002: Use symbols when looking up fields in a class (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/exceptions.cc

diff --git a/runtime/vm/exceptions.cc b/runtime/vm/exceptions.cc

index e2fa84e5de257b8ab4ce9ffa99bc395a877e3bc2..4e8b6fb9dca678975761f5e293d0a3292b145cd3 100644

--- a/runtime/vm/exceptions.cc

+++ b/runtime/vm/exceptions.cc

@@ -270,7 +270,8 @@ static RawField* LookupStacktraceField(const Instance& instance) {

AbstractType& type = AbstractType::Handle(zone, AbstractType::null());

while (true) {

if (test_class.raw() == error_class.raw()) {

- return error_class.LookupInstanceField(Symbols::_stackTrace());

+ return error_class.LookupInstanceFieldAllowPrivate(

+ Symbols::_stackTrace());

}

type = test_class.super_type();

if (type.IsNull()) return Field::null();