Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: components/mus/ws/focus_controller.h

Issue 1868783003: Makes SetFocus() notify callback correctly on failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/ws/display_unittest.cc ('k') | components/mus/ws/focus_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/ws/focus_controller.h
diff --git a/components/mus/ws/focus_controller.h b/components/mus/ws/focus_controller.h
index 113a1cba62cc29d61cedb38bb45e40a8871f4e1f..1dea308aa01f2a577da5454aacab87a08e8c6679 100644
--- a/components/mus/ws/focus_controller.h
+++ b/components/mus/ws/focus_controller.h
@@ -35,8 +35,9 @@ class FocusController : public ServerWindowDrawnTrackerObserver {
~FocusController() override;
// Sets the focused window. Does nothing if |window| is currently focused.
- // This does not notify the delegate.
- void SetFocusedWindow(ServerWindow* window);
+ // This does not notify the delegate. See ServerWindow::SetFocusedWindow()
+ // for details on return value.
+ bool SetFocusedWindow(ServerWindow* window);
ServerWindow* GetFocusedWindow();
// Moves activation to the next activatable window.
@@ -63,7 +64,7 @@ class FocusController : public ServerWindowDrawnTrackerObserver {
ServerWindow* GetActivatableAncestorOf(ServerWindow* window) const;
// Implementation of SetFocusedWindow().
- void SetFocusedWindowImpl(FocusControllerChangeSource change_source,
+ bool SetFocusedWindowImpl(FocusControllerChangeSource change_source,
ServerWindow* window);
// ServerWindowDrawnTrackerObserver:
« no previous file with comments | « components/mus/ws/display_unittest.cc ('k') | components/mus/ws/focus_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698