Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1868783003: Makes SetFocus() notify callback correctly on failure (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes SetFocus() notify callback correctly on failure SetFocus() may fail in the FocusController and this wasn't being propagated correctly to the client. This meant the client might think a window had focus when it didn't. BUG=600869 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1 Cr-Commit-Position: refs/heads/master@{#385866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -35 lines) Patch
M components/mus/ws/display.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/mus/ws/display.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/ws/display_unittest.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M components/mus/ws/focus_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M components/mus/ws/focus_controller.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/mus/ws/window_server.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/mus/ws/window_server.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M components/mus/ws/window_tree.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree.cc View 3 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-07 16:45:46 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-07 20:19:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868783003/1
4 years, 8 months ago (2016-04-07 20:20:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 21:24:37 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:30:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9b88e631421343f0fd3d695b9cee0b090eb6ac1
Cr-Commit-Position: refs/heads/master@{#385866}

Powered by Google App Engine
This is Rietveld 408576698