Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 18686005: Style resolution: Apply animation properties earlier in a separate pass (Closed)

Created:
7 years, 5 months ago by dstockwell
Modified:
7 years, 5 months ago
Reviewers:
dglazkov
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears, alancutter (OOO until 2018), Steve Block, shans, Timothy Loh, rjwright
Visibility:
Public.

Description

Style resolution: Apply animation properties earlier in a separate pass In order to apply the results of animations earlier in the style cascade we need to apply animation related properties, generate animations and trigger transitions earlier in the process. This change introduces a new pass in the style application process which allows animation properties to be applied after variable definitions but before high priority and low priority properties. Evaluated performance using html5-full-render perf test on Nexus 7 and observed no regression. Covered by existing tests. No change in behavior. BUG=232273 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154056

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Trim the fat. #

Patch Set 3 : Fix windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -59 lines) Patch
M Source/core/css/CSSPropertyNames.in View 4 chunks +23 lines, -21 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 6 chunks +47 lines, -38 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
dstockwell
7 years, 5 months ago (2013-07-10 12:29:22 UTC) #1
dglazkov
https://codereview.chromium.org/18686005/diff/3001/Source/core/css/resolver/StyleResolver.h File Source/core/css/resolver/StyleResolver.h (right): https://codereview.chromium.org/18686005/diff/3001/Source/core/css/resolver/StyleResolver.h#newcode349 Source/core/css/resolver/StyleResolver.h:349: { Why is the body of the function in ...
7 years, 5 months ago (2013-07-10 14:43:42 UTC) #2
dglazkov
lgtm once you trim the fat on StyleResolver.h :)
7 years, 5 months ago (2013-07-10 14:44:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18686005/11001
7 years, 5 months ago (2013-07-11 01:05:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18686005/11001
7 years, 5 months ago (2013-07-11 02:17:56 UTC) #5
commit-bot: I haz the power
Change committed as 153959
7 years, 5 months ago (2013-07-11 02:18:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18686005/27001
7 years, 5 months ago (2013-07-11 03:36:15 UTC) #7
commit-bot: I haz the power
Change committed as 153972
7 years, 5 months ago (2013-07-11 03:36:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18686005/27001
7 years, 5 months ago (2013-07-11 21:56:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16293
7 years, 5 months ago (2013-07-11 22:50:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/18686005/27001
7 years, 5 months ago (2013-07-11 23:02:23 UTC) #11
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 23:25:36 UTC) #12
Message was sent while issue was closed.
Change committed as 154056

Powered by Google App Engine
This is Rietveld 408576698