Style resolution: Apply animation properties earlier in a separate pass

Source/core/css/resolver/StyleResolver.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 322 matching lines @@
 
     void adjustRenderStyle(RenderStyle* styleToAdjust, RenderStyle* parentStyle, Element*);
     void adjustGridItemPosition(RenderStyle* styleToAdjust) const;
 
     bool fastRejectSelector(const RuleData&) const;
 
     void applyMatchedProperties(const MatchResult&, const Element*);
 
     enum StyleApplicationPass {
         VariableDefinitions,
+        AnimationProperties,
         HighPriorityProperties,
         LowPriorityProperties
     };
     template <StyleApplicationPass pass>
+    static bool isPropertyForPass(CSSPropertyID property)
+    {

[dglazkov, 2013/07/10 14:43:42]

Why is the body of the function in the header file? That's super-sad.

+        COMPILE_ASSERT(CSSPropertyVariable < firstCSSProperty, CSS_variable_is_before_first_property);
+        const CSSPropertyID firstAnimationProperty = CSSPropertyWebkitAnimation;
+        const CSSPropertyID lastAnimationProperty = CSSPropertyTransitionTimingFunction;
+        COMPILE_ASSERT(firstCSSProperty == firstAnimationProperty, CSS_first_animation_property_should_be_first_property);
+        const CSSPropertyID firstHighPriorityProperty = CSSPropertyColor;
+        const CSSPropertyID lastHighPriorityProperty = CSSPropertyLineHeight;
+        COMPILE_ASSERT(lastAnimationProperty + 1 == firstHighPriorityProperty, CSS_color_is_first_high_priority_property);
+        COMPILE_ASSERT(CSSPropertyLineHeight == firstHighPriorityProperty + 18, CSS_line_height_is_end_of_high_prioity_property_range);
+        COMPILE_ASSERT(CSSPropertyZoom == lastHighPriorityProperty - 1, CSS_zoom_is_before_line_height);
+        switch (pass) {
+        case VariableDefinitions:
+            return property == CSSPropertyVariable;
+        case AnimationProperties:
+            return property >= firstAnimationProperty && property <= lastAnimationProperty;
+        case HighPriorityProperties:
+            return property >= firstHighPriorityProperty && property <= lastHighPriorityProperty;
+        case LowPriorityProperties:
+            return property > lastHighPriorityProperty;
+        }
+    }
+    template <StyleApplicationPass pass>
     void applyMatchedProperties(const MatchResult&, bool important, int startIndex, int endIndex, bool inheritedOnly);
     template <StyleApplicationPass pass>
     void applyProperties(const StylePropertySet* properties, StyleRule*, bool isImportant, bool inheritedOnly, PropertyWhitelistType = PropertyWhitelistNone);
     template <StyleApplicationPass pass>
     void applyAnimatedProperties(const Element* target);
     void resolveVariables(CSSPropertyID, CSSValue*, Vector<std::pair<CSSPropertyID, String> >& knownExpressions);
     void matchPageRules(MatchResult&, RuleSet*, bool isLeftPage, bool isFirstPage, const String& pageName);
     void matchPageRulesForList(Vector<StyleRulePage*>& matchedRules, const Vector<StyleRulePage*>&, bool isLeftPage, bool isFirstPage, const String& pageName);
     Settings* documentSettings() { return m_document->settings(); }
 
@@ skipping 91 matching lines @@
         PseudoId ignoreDynamicPseudo = NOPSEUDO;
         if (selectorChecker.match(selectorCheckingContext, ignoreDynamicPseudo, DOMSiblingTraversalStrategy()) == SelectorChecker::SelectorMatches)
             return true;
     }
     return false;
 }
 
 } // namespace WebCore
 
 #endif // StyleResolver_h