Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1868553006: kitchen: emit valid JSON for SET_BUILD_PROPERTY annotations (Closed)

Created:
4 years, 8 months ago by Paweł Hajdan Jr.
Modified:
4 years, 8 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://github.com/luci/luci-go.git@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

kitchen: emit valid JSON for SET_BUILD_PROPERTY annotations Otherwise, we get exceptions from buildbot: remoteFailed: [Failure instance: Traceback: <type 'exceptions.ValueError'>: No JSON object could be decoded /usr/local/google/home/phajdan/infra_internal/build/third_party/twisted_10_2/twisted/spread/pb.py:516:expressionReceived /usr/local/google/home/phajdan/infra_internal/build/third_party/twisted_10_2/twisted/spread/pb.py:828:proto_message /usr/local/google/home/phajdan/infra_internal/build/third_party/twisted_10_2/twisted/spread/pb.py:842:_recvMessage /usr/local/google/home/phajdan/infra_internal/build/third_party/twisted_10_2/twisted/spread/flavors.py:114:remoteMessageReceived --- <exception caught here> --- /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/process/buildstep.py:176:remote_update /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/process/metrics.py:81:wrapper /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/process/buildstep.py:362:remoteUpdate /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/process/buildstep.py:333:addStdout /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/status/logfile.py:458:addStdout /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/status/logfile.py:454:addEntry /usr/local/google/home/phajdan/infra_internal/build/scripts/master/chromium_step.py:868:logChunk /usr/local/google/home/phajdan/infra_internal/build/scripts/master/chromium_step.py:875:outReceived /usr/local/google/home/phajdan/infra_internal/build/third_party/buildbot_8_4p1/buildbot/process/buildstep.py:455:outReceived /usr/local/google/home/phajdan/infra_internal/build/third_party/twisted_10_2/twisted/protocols/basic.py:455:dataReceived /usr/local/google/home/phajdan/infra_internal/build/scripts/master/chromium_step.py:860:outLineReceived /usr/local/google/home/phajdan/infra_internal/build/scripts/master/chromium_step.py:1047:handleOutputLine /usr/local/google/home/phajdan/infra_internal/build/scripts/common/annotator.py:324:MatchAnnotation /usr/local/google/home/phajdan/infra_internal/build/scripts/master/chromium_step.py:1061:SET_BUILD_PROPERTY /usr/lib/python2.7/json/__init__.py:338:loads /usr/lib/python2.7/json/decoder.py:366:decode /usr/lib/python2.7/json/decoder.py:384:raw_decode ] BUG=chromium:593999 Committed: https://github.com/luci/luci-go/commit/987d690898390cf368ca1839bdc5b98a860c86b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M client/cmd/kitchen/cook.go View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868553006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868553006/1
4 years, 8 months ago (2016-04-07 15:51:44 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 15:55:16 UTC) #4
M-A Ruel
lgtm
4 years, 8 months ago (2016-04-07 16:01:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868553006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868553006/1
4 years, 8 months ago (2016-04-07 16:04:06 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 16:06:04 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/987d690898390cf368ca1839bdc5b98a860c86b2

Powered by Google App Engine
This is Rietveld 408576698