client/cmd/kitchen/cook.go - Issue 1868553006: kitchen: emit valid JSON for SET_BUILD_PROPERTY annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/cmd/kitchen/cook.go

Issue 1868553006: kitchen: emit valid JSON for SET_BUILD_PROPERTY annotations (Closed) Base URL: https://github.com/luci/luci-go.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/cmd/kitchen/cook.go

diff --git a/client/cmd/kitchen/cook.go b/client/cmd/kitchen/cook.go

index fc6eb923562dfd66a434065bf3671a6c3793a0b1..3ed4b453994eff416ec95a0b99754850a30b97f7 100644

--- a/client/cmd/kitchen/cook.go

+++ b/client/cmd/kitchen/cook.go

@@ -182,7 +182,12 @@ func (c *cookRun) Run(a subcommands.Application, args []string) (exitCode int) {

}

for k, v := range props {

// Order is not stable, but that is okay.

- annotate("SET_BUILD_PROPERTY", k, fmt.Sprintf("%v", v))

+ jv, err := json.Marshal(v)

+ if err != nil {

+ fmt.Fprintln(os.Stderr, err)

+ return 1

+ }

+ annotate("SET_BUILD_PROPERTY", k, string(jv))

}

recipeExitCode, err := c.run(app.Context)

« no previous file with comments | « no previous file | no next file » | no next file with comments »