Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1868553002: [compiler] Remove obsolete GetUnoptimizedCodeCommon. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-internal-11
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete GetUnoptimizedCodeCommon. This removes an unnecessary abstraction from the implementation of the compilation pipeline that is no longer needed by now. R=bmeurer@chromium.org Committed: https://crrev.com/55515c998abbb3313081bfb40e9e2f46ce1e3c2b Cr-Commit-Position: refs/heads/master@{#35313}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -22 lines) Patch
M src/compiler.cc View 5 chunks +10 lines, -22 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-06 16:23:40 UTC) #3
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-06 17:45:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868553002/1
4 years, 8 months ago (2016-04-06 19:18:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 19:20:18 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:21:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55515c998abbb3313081bfb40e9e2f46ce1e3c2b
Cr-Commit-Position: refs/heads/master@{#35313}

Powered by Google App Engine
This is Rietveld 408576698