Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1860123003: [compiler] Remove CompilationInfo::opt_count field. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove CompilationInfo::opt_count field. This field duplicates information from the SharedFunctionInfo. Now that backends are guaranteed to have a SharedFunctionInfo around, we drop it. R=verwaest@chromium.org Committed: https://crrev.com/56c7d4b4f9d5793972543c3f9a194f1c7954d9f2 Cr-Commit-Position: refs/heads/master@{#35312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M src/compiler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/crankshaft/hydrogen.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +6 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen-gvn.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen-gvn.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-06 14:15:34 UTC) #1
Toon Verwaest
lgtm
4 years, 8 months ago (2016-04-06 19:11:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860123003/1
4 years, 8 months ago (2016-04-06 19:13:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 19:15:38 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:17:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56c7d4b4f9d5793972543c3f9a194f1c7954d9f2
Cr-Commit-Position: refs/heads/master@{#35312}

Powered by Google App Engine
This is Rietveld 408576698