Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1868533002: Move core/include/fxge to core/fxge/include. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move core/include/fxge to core/fxge/include. This CL is a straight move of the fxge includes into core/fxge/include. Committed: https://pdfium.googlesource.com/pdfium/+/48baa5f230a886b0579a9626711e7d71376b085e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -2545 lines) Patch
M BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_fontencoding.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3char.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/include/cpdf_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/ttgsubtable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorstate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_graphstate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_generalstatedata.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/include/cpdf_renderoptions.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/include/cpdf_textrenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_annot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/include/cpvt_wordprops.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_bmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_jpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_png.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_progress.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxcodec/codec/fx_codec_tiff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fpf_skiafont.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/android/fpf_skiafont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fpf_skiafontmgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fpf_skiamodule.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fx_android_font.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fx_android_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/android/fx_android_imp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/apple/apple_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/fx_apple_platform.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fxge/dib/dib_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_composite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/dib/fx_dib_convert.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_engine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_transform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/freetype/fx_freetype.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/ge/fx_ge_fontmap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/ge/fx_ge_linux.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_ps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/ge/fx_ge_text.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/ge/fx_text_int.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + core/fxge/include/fpf.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fxge/include/fx_dib.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fxge/include/fx_font.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + core/fxge/include/fx_freetype.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fxge/include/fx_ge.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + core/fxge/include/fx_ge_apple.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + core/fxge/include/fx_ge_win32.h View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/win32/fx_win32_dib.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/win32/fx_win32_dwrite.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/win32/fx_win32_gdipext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxge/win32/fx_win32_print.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fxge/win32/win32_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfdoc/fpdf_tagged.h View 1 chunk +1 line, -1 line 0 comments Download
D core/include/fxge/fpf.h View 1 chunk +0 lines, -70 lines 0 comments Download
D core/include/fxge/fx_dib.h View 1 chunk +0 lines, -669 lines 0 comments Download
D core/include/fxge/fx_font.h View 1 chunk +0 lines, -566 lines 0 comments Download
D core/include/fxge/fx_freetype.h View 1 chunk +0 lines, -180 lines 0 comments Download
D core/include/fxge/fx_ge.h View 1 chunk +0 lines, -733 lines 0 comments Download
D core/include/fxge/fx_ge_apple.h View 1 chunk +0 lines, -27 lines 0 comments Download
D core/include/fxge/fx_ge_win32.h View 1 chunk +0 lines, -98 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ComboBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListCtrl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Note.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ScrollBar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Signature.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 2 chunks +7 lines, -7 lines 0 comments Download
M testing/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M testing/libfuzzer/pdf_jpx_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download
M xfa/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fde/css/fde_css.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_brush.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_geobject.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_object.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/fde_renderdevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/fde_visualset.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fde/tto/fde_textout.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fee/ifde_txtedtengine.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fee/ifde_txtedtpage.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_font.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/font/fgas_stdfontmgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_textbreak.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/basewidget/ifx_barcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_themebackground.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/lightwidget/cfwl_theme.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_BufferedImageLuminanceSource.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_TwoDimWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/BC_Writer.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_codabar.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_code128.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_code39.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_codebase.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_datamatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_ean13.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_ean8.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_pdf417i.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_qrcode.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/cbc_upca.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxbarcode/oned/BC_OneDimWriter.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_localemgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cagg_graphics.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_color.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_path_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/cfx_shading.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxgraphics/include/cfx_graphics.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/include/fxfa/fxfa_objectacc.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/include/fxfa/xfa_ffwidget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. I'm planning on splitting these afterwards. fxge is used extensively, so splitting after moving ...
4 years, 8 months ago (2016-04-06 15:11:27 UTC) #2
Tom Sepez
LGTM. It may be worthwile to do more of these kinds of CLs (rather than ...
4 years, 8 months ago (2016-04-06 16:58:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868533002/1
4 years, 8 months ago (2016-04-06 17:00:02 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 17:00:45 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/48baa5f230a886b0579a9626711e7d71376b...

Powered by Google App Engine
This is Rietveld 408576698