Use PositionMoveType::GraphemeBoundary

Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923
Committed: https://crrev.com/d6ce8d254c7455534f38864d4c510a5af28620d8
Cr-Commit-Position: refs/heads/master@{#385999}

[Seigo Nonaka, 2016-04-06 10:33:19]

Description was changed from

==========
Use PositionMoveType::GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

The new PositionMoveType::CodePoint implementation is now empty since
nobody uses this moving type.

BUG=594923
==========

to

==========
Use PositionMoveType::GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

The new PositionMoveType::CodePoint implementation is now empty since
nobody uses this moving type now.

BUG=594923
==========

[Seigo Nonaka, 2016-04-06 10:33:39]

nona@chromium.org changed reviewers:
+ yosin@chromium.org

[Seigo Nonaka, 2016-04-06 10:33:39]

Hi Yoshi-san,

Could you kindly take a look?

Thank you.

[yosin_UTC9, 2016-04-07 01:13:56]

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:648:
NOTIMPLEMENTED() << moveType << " is not yet supported.";
Let's see results of layout test. If nothing is failed, we can get rid of
|PositionMoveType::CodePoint|.

[yosin_UTC9, 2016-04-07 01:17:33]

Since this patch change behavior of execCommand, we need to have layout tests
for changes.

[yosin_UTC9, 2016-04-08 00:50:55]

On 2016/04/07 at 01:17:33, Yosi_UTC9 wrote:
> Since this patch change behavior of execCommand, we need to have layout tests
for changes.
Correction, previous |PositionMoveType::CodePoint| uses grapheme cluster. So, it
doesn't change behavior except for Unicode 8.0.
Unicode 8.0 related changes are tested by unit test.

[yosin_UTC9, 2016-04-08 00:51:57]

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:705: case
PositionMoveType::CodePoint:
Since, nobody use |PositionMoveType::CodePoint|, could you get rid of this
rather than |NOTIMPLEMENTED()|?

[Seigo Nonaka, 2016-04-08 05:12:51]

Description was changed from

==========
Use PositionMoveType::GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

The new PositionMoveType::CodePoint implementation is now empty since
nobody uses this moving type now.

BUG=594923
==========

to

==========
Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923
==========

[yosin_UTC9, 2016-04-08 05:40:40]

lgtm

I really appreciate for your contribution!
(^_^)b

[Seigo Nonaka, 2016-04-08 05:47:45]

I'm sorry I forgot sending reply.

Thank you very much! 

Submitting...

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:648:
NOTIMPLEMENTED() << moveType << " is not yet supported.";
On 2016/04/07 01:13:56, Yosi_UTC9 wrote:
> Let's see results of layout test. If nothing is failed, we can get rid of
> |PositionMoveType::CodePoint|. 

Done.

https://codereview.chromium.org/1868473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:705: case
PositionMoveType::CodePoint:
On 2016/04/08 00:51:57, Yosi_UTC9 wrote:
> Since, nobody use |PositionMoveType::CodePoint|, could you get rid of this
> rather than |NOTIMPLEMENTED()|?

Done.

[Seigo Nonaka, 2016-04-08 05:47:49]

The CQ bit was checked by nona@chromium.org

[commit-bot: I haz the power, 2016-04-08 05:48:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868473002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868473002/20001

[commit-bot: I haz the power, 2016-04-08 05:53:00]

Description was changed from

==========
Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923
==========

to

==========
Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923
==========

[commit-bot: I haz the power, 2016-04-08 05:53:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-08 05:54:11]

Description was changed from

==========
Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923
==========

to

==========
Replace PositionMoveType::CodePoint with GraphemeBoundary

All usage of previousPositionOf/nextPositionOf in editing is grapheme
cluster boundary based movement. Replace all function call for
PositionMoveType::CodePoint with PositionMoveType::GraphemeBoundary.

BUG=594923

Committed: https://crrev.com/d6ce8d254c7455534f38864d4c510a5af28620d8
Cr-Commit-Position: refs/heads/master@{#385999}
==========

[commit-bot: I haz the power, 2016-04-08 05:54:12]

Patchset 2 (id:??) landed as
https://crrev.com/d6ce8d254c7455534f38864d4c510a5af28620d8
Cr-Commit-Position: refs/heads/master@{#385999}