third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp - Issue 1868473002: Use PositionMoveType::GraphemeBoundary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

Issue 1868473002: Use PositionMoveType::GraphemeBoundary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PositionMoveType::CodePoint Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

index f7cb54c246d46f07395ebd5c681346d118e72d76..2552dc6ebb89eed4f6413f9832f71f72af0b519c 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilitiesTest.cpp

@@ -156,8 +156,8 @@ TEST_F(EditingUtilitiesTest, NextNodeIndex)

Node* host = document().getElementById("host");

Node* two = document().getElementById("two");

- EXPECT_EQ(Position(host, 3), nextPositionOf(Position(two, 2), PositionMoveType::CodePoint));

- EXPECT_EQ(PositionInFlatTree(host, 1), nextPositionOf(PositionInFlatTree(two, 2), PositionMoveType::CodePoint));

+ EXPECT_EQ(Position(host, 3), nextPositionOf(Position(two, 2), PositionMoveType::GraphemeCluster));

+ EXPECT_EQ(PositionInFlatTree(host, 1), nextPositionOf(PositionInFlatTree(two, 2), PositionMoveType::GraphemeCluster));

}

TEST_F(EditingUtilitiesTest, NextVisuallyDistinctCandidate)