Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1868133002: Revert "Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" (Closed)

Created:
4 years, 8 months ago by phoglund_chromium
Modified:
4 years, 8 months ago
Reviewers:
emircan
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" Speculative revert: appears to cause timeouts and lots of ERROR:video_sender.cc(313)] Failed to encode frame. Error code: -1 errors on WebRTC Mac bots for the h264 tests. BUG=597334 TBR=emircan@chromium.org Committed: https://crrev.com/62ed28f34a448143ed210990c59ecd94c53e53ef Cr-Commit-Position: refs/heads/master@{#386018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868133002/1
4 years, 8 months ago (2016-04-08 07:35:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 08:36:25 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 08:37:49 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62ed28f34a448143ed210990c59ecd94c53e53ef
Cr-Commit-Position: refs/heads/master@{#386018}

Powered by Google App Engine
This is Rietveld 408576698