Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Side by Side Diff: content/renderer/media/rtc_video_encoder_factory.cc

Issue 1868133002: Revert "Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/rtc_video_encoder_factory.h" 5 #include "content/renderer/media/rtc_video_encoder_factory.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "content/public/common/content_switches.h" 8 #include "content/public/common/content_switches.h"
9 #include "content/public/common/feature_h264_with_openh264_ffmpeg.h"
10 #include "content/renderer/media/rtc_video_encoder.h" 9 #include "content/renderer/media/rtc_video_encoder.h"
11 #include "media/gpu/ipc/client/gpu_video_encode_accelerator_host.h" 10 #include "media/gpu/ipc/client/gpu_video_encode_accelerator_host.h"
12 #include "media/renderers/gpu_video_accelerator_factories.h" 11 #include "media/renderers/gpu_video_accelerator_factories.h"
13 #include "media/video/video_encode_accelerator.h" 12 #include "media/video/video_encode_accelerator.h"
14 13
15 namespace content { 14 namespace content {
16 15
17 namespace { 16 namespace {
18 17
19 // Translate from media::VideoEncodeAccelerator::SupportedProfile to 18 // Translate from media::VideoEncodeAccelerator::SupportedProfile to
20 // one or more instances of cricket::WebRtcVideoEncoderFactory::VideoCodec 19 // one or more instances of cricket::WebRtcVideoEncoderFactory::VideoCodec
21 void VEAToWebRTCCodecs( 20 void VEAToWebRTCCodecs(
22 std::vector<cricket::WebRtcVideoEncoderFactory::VideoCodec>* codecs, 21 std::vector<cricket::WebRtcVideoEncoderFactory::VideoCodec>* codecs,
23 const media::VideoEncodeAccelerator::SupportedProfile& profile) { 22 const media::VideoEncodeAccelerator::SupportedProfile& profile) {
24 const int width = profile.max_resolution.width(); 23 const int width = profile.max_resolution.width();
25 const int height = profile.max_resolution.height(); 24 const int height = profile.max_resolution.height();
26 const int fps = profile.max_framerate_numerator; 25 const int fps = profile.max_framerate_numerator;
27 DCHECK_EQ(profile.max_framerate_denominator, 1U); 26 DCHECK_EQ(profile.max_framerate_denominator, 1U);
28 27
29 const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess(); 28 const base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
30 if (profile.profile >= media::VP8PROFILE_MIN && 29 if (profile.profile >= media::VP8PROFILE_MIN &&
31 profile.profile <= media::VP8PROFILE_MAX) { 30 profile.profile <= media::VP8PROFILE_MAX) {
32 codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec( 31 codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
33 webrtc::kVideoCodecVP8, "VP8", width, height, fps)); 32 webrtc::kVideoCodecVP8, "VP8", width, height, fps));
34 } else if (profile.profile >= media::H264PROFILE_MIN && 33 } else if (profile.profile >= media::H264PROFILE_MIN &&
35 profile.profile <= media::H264PROFILE_MAX) { 34 profile.profile <= media::H264PROFILE_MAX) {
36 bool webrtc_h264_enabled = false; 35 if (cmd_line->HasSwitch(switches::kEnableWebRtcHWH264Encoding)) {
37 #if BUILDFLAG(RTC_USE_H264) && defined(OS_MACOSX)
38 webrtc_h264_enabled =
39 base::FeatureList::IsEnabled(kWebRtcH264WithOpenH264FFmpeg);
40 #endif // BUILDFLAG(RTC_USE_H264) && defined(OS_MACOSX)
41 if (cmd_line->HasSwitch(switches::kEnableWebRtcHWH264Encoding) ||
42 webrtc_h264_enabled) {
43 codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec( 36 codecs->push_back(cricket::WebRtcVideoEncoderFactory::VideoCodec(
44 webrtc::kVideoCodecH264, "H264", width, height, fps)); 37 webrtc::kVideoCodecH264, "H264", width, height, fps));
45 } 38 }
46 } 39 }
47 } 40 }
48 41
49 } // anonymous namespace 42 } // anonymous namespace
50 43
51 RTCVideoEncoderFactory::RTCVideoEncoderFactory( 44 RTCVideoEncoderFactory::RTCVideoEncoderFactory(
52 media::GpuVideoAcceleratorFactories* gpu_factories) 45 media::GpuVideoAcceleratorFactories* gpu_factories)
(...skipping 19 matching lines...) Expand all
72 RTCVideoEncoderFactory::codecs() const { 65 RTCVideoEncoderFactory::codecs() const {
73 return codecs_; 66 return codecs_;
74 } 67 }
75 68
76 void RTCVideoEncoderFactory::DestroyVideoEncoder( 69 void RTCVideoEncoderFactory::DestroyVideoEncoder(
77 webrtc::VideoEncoder* encoder) { 70 webrtc::VideoEncoder* encoder) {
78 delete encoder; 71 delete encoder;
79 } 72 }
80 73
81 } // namespace content 74 } // namespace content
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698