src/IceInst.cpp - Issue 1868113002: Subzero: Shorten and normalize strings in non-DUMP builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.cpp

Issue 1868113002: Subzero: Shorten and normalize strings in non-DUMP builds. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp

index 8412b0535b8a8fce90a1161cec7cbc78ef0019bd..698d3214ec7777cb6f4f7dc4ba0230d0906ee01a 100644

--- a/src/IceInst.cpp

+++ b/src/IceInst.cpp

@@ -579,7 +579,7 @@ GlobalString makeName(Cfg *Func, const SizeT Id) {

return GlobalString::createWithString(

Ctx, ".L" + FuncName.toString() + "$jumptable$__" + std::to_string(Id));

return GlobalString::createWithString(

- Ctx, ".L" + std::to_string(FuncName.getID()) + "_" + std::to_string(Id));

+ Ctx, "_J" + std::to_string(FuncName.getID()) + "_" + std::to_string(Id));

John 2016/04/08 15:47:46 why not $J? that would pretty much guarantee no cl

Jim Stichnoth 2016/04/09 15:54:09 Done.

}

} // end of anonymous namespace

« no previous file with comments | « no previous file | src/IceOperand.h » ('j') | no next file with comments »