Subzero: Shorten and normalize strings in non-DUMP builds.

src/IceInst.cpp

 //===- subzero/src/IceInst.cpp - High-level instruction implementation ----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 561 matching lines @@
     : InstHighLevel(Func, Inst::FakeKill, 0, nullptr), Linked(Linked) {}
 
 namespace {
 GlobalString makeName(Cfg *Func, const SizeT Id) {
   const auto FuncName = Func->getFunctionName();
   auto *Ctx = Func->getContext();
   if (FuncName.hasStdString())
     return GlobalString::createWithString(
         Ctx, ".L" + FuncName.toString() + "$jumptable$__" + std::to_string(Id));
   return GlobalString::createWithString(
-      Ctx, ".L" + std::to_string(FuncName.getID()) + "_" + std::to_string(Id));
+      Ctx, "_J" + std::to_string(FuncName.getID()) + "_" + std::to_string(Id));

[John, 2016/04/08 15:47:46]

why not $J? that would pretty much guarantee no clashes with C(++) identifiers.

[Jim Stichnoth, 2016/04/09 15:54:09]

Done.

 }
 } // end of anonymous namespace
 
 InstJumpTable::InstJumpTable(Cfg *Func, SizeT NumTargets, CfgNode *Default)
     : InstHighLevel(Func, Inst::JumpTable, 1, nullptr),
       Id(Func->getTarget()->makeNextJumpTableNumber()), NumTargets(NumTargets),
       Name(makeName(Func, Id)), FuncName(Func->getFunctionName()) {
   Targets = Func->allocateArrayOf<CfgNode *>(NumTargets);
   for (SizeT I = 0; I < NumTargets; ++I) {
     Targets[I] = Default;
@@ skipping 463 matching lines @@
     // upper 32 bits of rax. We need to recognize and preserve these.
     return true;
   }
   if (!Dest->hasReg() && !SrcVar->hasReg() &&
       Dest->getStackOffset() == SrcVar->getStackOffset())
     return true;
   return false;
 }
 
 } // end of namespace Ice